aboutsummaryrefslogtreecommitdiffstats
path: root/Library/Homebrew
diff options
context:
space:
mode:
authorJack Nagel2014-10-17 00:35:51 -0500
committerJack Nagel2014-10-17 00:35:51 -0500
commitcf76b97da9a682384c81e48eb813254304df5d5d (patch)
treef85fcf9fd7e8fc185c4f897ddf6498d87a78a572 /Library/Homebrew
parent7d681c763eba133716ebfdcc1f6570933c8d04cb (diff)
downloadhomebrew-cf76b97da9a682384c81e48eb813254304df5d5d.tar.bz2
audit: call puts once instead of problems.size + 2 times
Diffstat (limited to 'Library/Homebrew')
-rw-r--r--Library/Homebrew/cmd/audit.rb9
1 files changed, 2 insertions, 7 deletions
diff --git a/Library/Homebrew/cmd/audit.rb b/Library/Homebrew/cmd/audit.rb
index a0359ae07..4b9aba93c 100644
--- a/Library/Homebrew/cmd/audit.rb
+++ b/Library/Homebrew/cmd/audit.rb
@@ -22,11 +22,9 @@ module Homebrew
fa.audit
unless fa.problems.empty?
- puts "#{f.name}:"
- fa.problems.each { |p| puts " * #{p}" }
- puts
formula_count += 1
problem_count += fa.problems.size
+ puts "#{f.name}:", fa.problems.map { |p| " * #{p}" }, ""
end
end
@@ -153,10 +151,7 @@ class FormulaAuditor
next if dep.build? or dep.run?
problem %{#{dep} dependency should be "depends_on '#{dep}' => :build"}
when "git", "ruby", "mercurial"
- problem <<-EOS.undent
- Don't use #{dep} as a dependency. We allow non-Homebrew
- #{dep} installations.
- EOS
+ problem "Don't use #{dep} as a dependency. We allow non-Homebrew #{dep} installations."
when 'gfortran'
problem "Use `depends_on :fortran` instead of `depends_on 'gfortran'`"
when 'open-mpi', 'mpich2'