Replace files atomically in inreplace

1 files changed, 3 insertions, 6 deletions

diff --git a/Library/Homebrew/utils/inreplace.rb b/Library/Homebrew/utils/inreplace.rb
index 4fa2fbe7c..a6451c49f 100644
--- a/Library/Homebrew/utils/inreplace.rb
+++ b/Library/Homebrew/utils/inreplace.rb
@@ -2,12 +2,10 @@ module Utils
   module Inreplace
     def inreplace paths, before=nil, after=nil
       Array(paths).each do |path|
-        f = File.open(path, 'rb')
-        s = f.read
+        s = File.open(path, "rb", &:read)
 
         if before.nil? && after.nil?
-          s.extend(StringInreplaceExtension)
-          yield s
+          yield s.extend(StringInreplaceExtension)
         else
           after = after.to_s if Symbol === after
           unless s.gsub!(before, after)
@@ -19,8 +17,7 @@ module Utils
           end
         end
 
-        f.reopen(path, 'wb').write(s)
-        f.close
+        Pathname(path).atomic_write(s)
       end
     end
   end