diff options
| author | Jack Nagel | 2013-08-19 12:32:58 -0500 |
|---|---|---|
| committer | Jack Nagel | 2013-08-19 12:32:58 -0500 |
| commit | 938c7f7df40abf2a21bc89731a5f3ef3e177162f (patch) | |
| tree | 5198dfc6a83d6f30fe002612aa3e98ef10db4d48 /Library/Homebrew/requirements/python_dependency.rb | |
| parent | fcec094f60fa43b83123913b7e85b56bc8bec899 (diff) | |
| download | homebrew-938c7f7df40abf2a21bc89731a5f3ef3e177162f.tar.bz2 | |
Fix superenv ENV[] hack
We override ENV[] to always return strings under superenv, because
legacy formulae assume that CFLAGS, etc. are non-nil.
However, the current implementation has a bug. If I simply concatenate
ENV['CFLAGS'] with another string, it mutates ENV['CFLAGS']:
irb> ENV['CFLAGS']
=> ""
irb> ENV['CFLAGS'] + 'a'
=> "a"
irb> ENV['CFLAGS']
=> "a"
Instead, let's simply return an empty string if the key doesn't exist.
This is sufficient because the following are equivalent:
1. ENV['CFLAGS'] += "string"
2. ENV['CFLAGS'] = ENV['CFLAGS'] + "string"
Diffstat (limited to 'Library/Homebrew/requirements/python_dependency.rb')
0 files changed, 0 insertions, 0 deletions
