aboutsummaryrefslogtreecommitdiffstats
path: root/Library/Homebrew/cmd
diff options
context:
space:
mode:
authorJack Nagel2011-11-29 19:37:39 -0600
committerJack Nagel2011-11-29 19:40:14 -0600
commitead6a69541fe0ddd6193e816cbe0d4706bb74dd2 (patch)
tree7f2aa35322359fc6910db24d71ade9169c61b51c /Library/Homebrew/cmd
parent33c598f82f0f48a893f95cdf0ec1b8549e37e670 (diff)
downloadhomebrew-ead6a69541fe0ddd6193e816cbe0d4706bb74dd2.tar.bz2
audit: check for build-time dependencies
This can be made more robust in the future when we stop throwing away the ':build' type flag in Formula#depends_on. Signed-off-by: Jack Nagel <jacknagel@gmail.com>
Diffstat (limited to 'Library/Homebrew/cmd')
-rwxr-xr-xLibrary/Homebrew/cmd/audit.rb5
1 files changed, 5 insertions, 0 deletions
diff --git a/Library/Homebrew/cmd/audit.rb b/Library/Homebrew/cmd/audit.rb
index ede2ad3a3..761d3f643 100755
--- a/Library/Homebrew/cmd/audit.rb
+++ b/Library/Homebrew/cmd/audit.rb
@@ -29,6 +29,11 @@ def audit_formula_text name, text
problems << " * Check indentation of 'depends_on'."
end
+ # cmake, pkg-config, and scons are build-time deps
+ if text =~ /depends_on ['"](cmake|pkg-config|scons)['"]$/
+ problems << " * #{$1} dependency should be \"depends_on '#{$1}' => :build\""
+ end
+
# FileUtils is included in Formula
if text =~ /FileUtils\.(\w+)/
problems << " * Don't need 'FileUtils.' before #{$1}."