Simplify valid_formula_location? method

1 files changed, 7 insertions, 6 deletions

diff --git a/Library/Homebrew/cmd/update.rb b/Library/Homebrew/cmd/update.rb
index 6166571cd..042214ee3 100644
--- a/Library/Homebrew/cmd/update.rb
+++ b/Library/Homebrew/cmd/update.rb
@@ -232,13 +232,14 @@ class Report < Hash
   end
 
   def valid_formula_location?(relative_path)
-    ruby_file = /\A.*\.rb\Z/
     parts = relative_path.split('/')[2..-1]
-    [
-      parts.length == 1 && parts.first =~ ruby_file,
-      parts.length == 2 && parts.first == 'Formula' && parts.last =~ ruby_file,
-      parts.length == 2 && parts.first == 'HomebrewFormula' && parts.last =~ ruby_file,
-    ].any?
+    return false unless File.extname(parts.last) == ".rb"
+    case parts.first
+    when "Formula", "HomebrewFormula"
+      parts.length == 2
+    else
+      parts.length == 1
+    end
   end
 
   def new_tapped_formula