aboutsummaryrefslogtreecommitdiffstats
path: root/Library/Homebrew/cmd
diff options
context:
space:
mode:
authorMike McQuaid2015-03-20 17:45:48 +0000
committerMike McQuaid2015-03-20 17:46:19 +0000
commit617ad1e1d0b88a9bf1afaeb3e0cd553c2867428d (patch)
treea67702d9ed79fe9c0ac93869a7d35fcab28ed411 /Library/Homebrew/cmd
parent0d99e7a55fc10ad508a196902afcd9c9cc57e5d1 (diff)
downloadhomebrew-617ad1e1d0b88a9bf1afaeb3e0cd553c2867428d.tar.bz2
pull: die on invalid parameters.
Diffstat (limited to 'Library/Homebrew/cmd')
-rw-r--r--Library/Homebrew/cmd/pull.rb9
1 files changed, 3 insertions, 6 deletions
diff --git a/Library/Homebrew/cmd/pull.rb b/Library/Homebrew/cmd/pull.rb
index 654ef1fe6..074ced1ee 100644
--- a/Library/Homebrew/cmd/pull.rb
+++ b/Library/Homebrew/cmd/pull.rb
@@ -50,11 +50,11 @@ module Homebrew
def pull
if ARGV.empty?
- onoe 'This command requires at least one argument containing a URL or pull request number'
+ odie 'This command requires at least one argument containing a URL or pull request number'
end
if ARGV[0] == '--rebase'
- onoe 'You meant `git pull --rebase`.'
+ odie 'You meant `git pull --rebase`.'
end
ARGV.named.each do |arg|
@@ -68,10 +68,7 @@ module Homebrew
end
url_match = arg.match HOMEBREW_PULL_OR_COMMIT_URL_REGEX
- unless url_match
- ohai 'Ignoring URL:', "Not a GitHub pull request or commit: #{arg}"
- next
- end
+ odie "Not a GitHub pull request or commit: #{arg}" unless url_match
url = url_match[0]
issue = url_match[3]