diff options
| author | Xiyue Deng | 2013-10-24 22:57:09 -0700 |
|---|---|---|
| committer | Xiyue Deng | 2013-10-24 23:08:48 -0700 |
| commit | dde0fbd8349594b036666eea02a075b6668003dc (patch) | |
| tree | 7f3b5214ddd58c8933465c68590a68444dda0cb9 /Library/Formula | |
| parent | 14b865c31c8c62c3db6c44686abea418496c5f93 (diff) | |
| download | homebrew-dde0fbd8349594b036666eea02a075b6668003dc.tar.bz2 | |
flac: stylenit.
* Add comments for Mavericks workaround.
* Reference upstream bug report and patch.
* Use symbol form for autotools.
Diffstat (limited to 'Library/Formula')
| -rw-r--r-- | Library/Formula/flac.rb | 21 |
1 files changed, 13 insertions, 8 deletions
diff --git a/Library/Formula/flac.rb b/Library/Formula/flac.rb index 4f18b1296..4470e1924 100644 --- a/Library/Formula/flac.rb +++ b/Library/Formula/flac.rb @@ -10,10 +10,13 @@ class Flac < Formula depends_on 'xz' => :build depends_on 'lame' depends_on 'libogg' => :optional + + # Mavericks fix needs autoreconf. Drop these after upstream has + # incorporated the patch. + depends_on :autoconf => :build + depends_on :automake => :build + depends_on :libtool => :build depends_on 'pkg-config' => :build - depends_on 'libtool' => :build - depends_on 'automake' => :build - depends_on 'autoconf' => :build fails_with :llvm do build 2326 @@ -21,17 +24,19 @@ class Flac < Formula end def patches - #fixes compilation on mac os 10.9 maverick - [ - "https://gist.github.com/leiflm/7139949/raw" - ] + # Fixes compilation on mac os 10.9 maverick. + # https://sourceforge.net/p/flac/bugs/405/ + { :p0 => "https://sourceforge.net/p/flac/bugs/_discuss/thread/17c68b42/fc53/attachment/autoconf-not-gnu89-131010.patch" } end def install ENV.universal_binary if build.universal? - # sadly the asm optimisations won't compile since Leopard + # Mavericks fix needs autoreconf. Drop this line after upstream has + # incorporated the patch. system "./autogen.sh" + + # sadly the asm optimisations won't compile since Leopard system "./configure", "--disable-dependency-tracking", "--disable-debug", "--disable-asm-optimizations", |