diff options
| author | Jack Nagel | 2012-01-27 03:19:53 -0600 |
|---|---|---|
| committer | Jack Nagel | 2012-01-27 03:40:24 -0600 |
| commit | 8975242faafe186be13365576fb1adacaf67e8ab (patch) | |
| tree | ef91f4f28f3f1b8d486db208ea3fd2771a9599c7 /Library/Formula | |
| parent | e464a386a5824ab656cbed60c6df765849e93a55 (diff) | |
| download | homebrew-8975242faafe186be13365576fb1adacaf67e8ab.tar.bz2 | |
versions: fix up error handling
Now we handle some things more explicitly and in the process get rid of
the blanket rescue on the mktemp block, which is something of an
antipattern.
By unloading the class *after* determining the version, we avoid the
case where the class had previously been unloaded but Formula.factory
failed, and trying to unload the nonexistent class results in a
NameError. Doing it this way, we avoid having to rescue NameError and
thereby avoid hiding other cases where it may occur.
We also rescue TypeError which gets us past a few more bad formula in
the history in some instances.
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
Diffstat (limited to 'Library/Formula')
0 files changed, 0 insertions, 0 deletions
