diff options
| author | Dominyk Tiller | 2014-12-01 05:17:15 +0000 |
|---|---|---|
| committer | Mike McQuaid | 2014-12-01 08:11:01 +0000 |
| commit | 61883d5d625221c2469ed1f265a2e8a639defa0e (patch) | |
| tree | c7687546f733492a3571e4d174e1228414b6a694 /Library/Formula | |
| parent | 3698cb469047cb8d9056b6443fc5de7f55a19782 (diff) | |
| download | homebrew-61883d5d625221c2469ed1f265a2e8a639defa0e.tar.bz2 | |
git: fix broken svn option if no swig exists prior.
Resolves the bug where installing Git with brewed-svn wouldn't
automatically drag in the required Swig dependency and consequently
the build would instantly error out.
The error itself could be with the subversion formulae or Homebrew
itself, and this may just be a workaround. Given building git
with-brewed-svn specifies svn with perl, it should trigger a swig
download automatically prior to attempting to install the svn dep,
but for some reason it doesn't.
Both from-source and from-bottle installs error out in the same way:
```
==> Installing git dependency: subversion
Error: /usr/local/opt/swig not present or broken
Please reinstall swig. Sorry :(
```
For now, have resolved this bug by dragging in an explicit swig
dependency prior to the subversion one, if you choose to install
with-brewed-svn.
Closes #34554.
Closes #34576.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
Diffstat (limited to 'Library/Formula')
| -rw-r--r-- | Library/Formula/git.rb | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/Library/Formula/git.rb b/Library/Formula/git.rb index 4a0283110..d3cbbd68c 100644 --- a/Library/Formula/git.rb +++ b/Library/Formula/git.rb @@ -36,7 +36,12 @@ class Git < Formula depends_on "openssl" if build.with? "brewed-openssl" depends_on "curl" if build.with? "brewed-curl" depends_on "go" => :build if build.with? "persistent-https" - depends_on "subversion" => "perl" if build.with? "brewed-svn" + # Trigger an install of swig before subversion, as the "swig" doesn't get pulled in otherwise + # See https://github.com/Homebrew/homebrew/issues/34554 + if build.with? "brewed-svn" + depends_on "swig" + depends_on "subversion" => "perl" + end def install # If these things are installed, tell Git build system to not use them |