Update formulae for version 0.7

* Use new "url" features
* Use keg_only DSL
* Use "skip_clean :all" DSL
* Whitespace and style cleanups
* Make bash invocations less silly
* Use new man2-man8 helpers
* Remove "FileUtils." since it is included in Formula
* Use real names for deps instead of aliases
* ENV.x11 now updates path, so remove that from individual brews

1 files changed, 14 insertions, 19 deletions

diff --git a/Library/Formula/postgresql.rb b/Library/Formula/postgresql.rb
index 0366b6286..f35ea0be9 100755
--- a/Library/Formula/postgresql.rb
+++ b/Library/Formula/postgresql.rb
@@ -19,42 +19,37 @@ class Postgresql <Formula
     ]
   end
 
-  def skip_clean? path
-    true
-  end
+  skip_clean :all
 
   def install
     ENV.libxml2 if MACOS_VERSION >= 10.6
 
-    configure_args = [
-        "--enable-thread-safety",
-        "--with-bonjour",
-        "--with-gssapi",
-        "--with-krb5",
-        "--with-openssl",
-        "--with-libxml",
-        "--with-libxslt",
-        "--prefix=#{prefix}",
-        "--disable-debug"
-    ]
+    args = ["--disable-debug",
+            "--prefix=#{prefix}",
+            "--enable-thread-safety",
+            "--with-bonjour",
+            "--with-gssapi",
+            "--with-krb5",
+            "--with-openssl",
+            "--with-libxml", "--with-libxslt"]
 
-    configure_args << "--with-python" unless ARGV.include? '--no-python'
-    configure_args << "--with-perl" unless ARGV.include? '--no-perl'
+    args << "--with-python" unless ARGV.include? '--no-python'
+    args << "--with-perl" unless ARGV.include? '--no-perl'
 
-    configure_args << "--with-ossp-uuid"
+    args << "--with-ossp-uuid"
     ENV.append 'CFLAGS', `uuid-config --cflags`.strip
     ENV.append 'LDFLAGS', `uuid-config --ldflags`.strip
     ENV.append 'LIBS', `uuid-config --libs`.strip
 
     if bits_64? and not ARGV.include? '--no-python'
-      configure_args << "ARCHFLAGS='-arch x86_64'"
+      args << "ARCHFLAGS='-arch x86_64'"
       check_python_arch
     end
 
     # Fails on Core Duo with O4 and O3
     ENV.O2 if Hardware.intel_family == :core
 
-    system "./configure", *configure_args
+    system "./configure", *args
     system "make install"
 
     %w[ adminpack dblink fuzzystrmatch lo uuid-ossp pg_buffercache pg_trgm