diff options
| author | Jack Nagel | 2012-05-15 13:31:21 -0500 |
|---|---|---|
| committer | Jack Nagel | 2012-05-15 14:03:11 -0500 |
| commit | 417d7880702a645a5efd272a42dd03a8e7419035 (patch) | |
| tree | 62ec77b19613a1a35f82011c3d931f5409e69384 /Library/Formula/audiofile.rb | |
| parent | 5d3217437e0455f143d33061718fbea0c6ee0277 (diff) | |
| download | homebrew-417d7880702a645a5efd272a42dd03a8e7419035.tar.bz2 | |
Shore up a number of shell quoting issues
When interpolating in strings passed to Formula#system, it should be
done in such a way that if any interpolated variables contain spaces,
they are either (a) passed as part of a list or (b) protected by quotes
if they are part of a long string (which is subject to shell expansion).
Otherwise, they will be split on the space when expanded by the shell
and passed as multiple arguments to whatever process is being executed.
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
Diffstat (limited to 'Library/Formula/audiofile.rb')
| -rw-r--r-- | Library/Formula/audiofile.rb | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/Library/Formula/audiofile.rb b/Library/Formula/audiofile.rb index 8e2e864ba..95601fb1a 100644 --- a/Library/Formula/audiofile.rb +++ b/Library/Formula/audiofile.rb @@ -47,9 +47,9 @@ class Audiofile < Formula end mktemp do - system "#{conv_bin} #{inn} #{out} format wave" - system "#{info_bin} --short --reporterror #{out}" - system "#{hear_bin} -p #{out}" if ARGV.verbose? + system conv_bin, inn, out, 'format', 'wave' + system info_bin, '--short', '--reporterror', out + system hear_bin, '-p', out if ARGV.verbose? end end end |
