diff options
| author | Jack Nagel | 2014-07-19 20:25:16 -0500 |
|---|---|---|
| committer | Jack Nagel | 2014-07-19 20:25:32 -0500 |
| commit | 2975a7361a1457ffe448c2dcdf3ae8e11db02d4f (patch) | |
| tree | 583af83b2fcceb953749259de1f05c1d86e8f7f7 /Library/Contributions/cmd | |
| parent | 3c6951ca3072c76af19d096e1332c31de07426c6 (diff) | |
| download | homebrew-2975a7361a1457ffe448c2dcdf3ae8e11db02d4f.tar.bz2 | |
Improve pull request URL regexp
- use a regexp literal and avoid escaping forward slashes
- escape the period in "github.com"
- match only hex characters in the commit part
- allow hyphen in usernames and repo names, matching what we allow for
tap names
- avoid unnecessary capture
Diffstat (limited to 'Library/Contributions/cmd')
| -rwxr-xr-x | Library/Contributions/cmd/brew-pull.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/Library/Contributions/cmd/brew-pull.rb b/Library/Contributions/cmd/brew-pull.rb index c8bc74049..f6f17a211 100755 --- a/Library/Contributions/cmd/brew-pull.rb +++ b/Library/Contributions/cmd/brew-pull.rb @@ -29,7 +29,7 @@ ARGV.named.each do |arg| end url = url_match[0] - issue = url_match[4] + issue = url_match[3] end if tap_name = tap(url) |
