aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJack Nagel2014-12-31 10:37:29 -0500
committerJack Nagel2014-12-31 10:38:04 -0500
commitefaed83e2e2f7b14f18317249cb6e7c5c7da6d37 (patch)
tree37689a1e9d6c275cadef15ab91c764ec2ef853b2
parent4b4e97b496ef22f4dc2a0f213bcf23436716e7c8 (diff)
downloadhomebrew-efaed83e2e2f7b14f18317249cb6e7c5c7da6d37.tar.bz2
Don't attempt to detect version if URL is not set
-rw-r--r--Library/Homebrew/resource.rb2
-rw-r--r--Library/Homebrew/test/test_resource.rb4
2 files changed, 6 insertions, 0 deletions
diff --git a/Library/Homebrew/resource.rb b/Library/Homebrew/resource.rb
index 573a7bcb1..0b30d72ad 100644
--- a/Library/Homebrew/resource.rb
+++ b/Library/Homebrew/resource.rb
@@ -148,6 +148,8 @@ class Resource
private
def detect_version(val)
+ return if val.nil? && url.nil?
+
case val
when nil then Version.detect(url, specs)
when String then Version.new(val)
diff --git a/Library/Homebrew/test/test_resource.rb b/Library/Homebrew/test/test_resource.rb
index e5cb288d2..245bc1789 100644
--- a/Library/Homebrew/test/test_resource.rb
+++ b/Library/Homebrew/test/test_resource.rb
@@ -81,6 +81,10 @@ class ResourceTests < Homebrew::TestCase
assert_raises(TypeError) { @resource.version(Object.new) }
end
+ def test_version_when_url_is_not_set
+ assert_nil @resource.version
+ end
+
def test_mirrors
assert_empty @resource.mirrors
@resource.mirror('foo')