aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJack Nagel2014-05-27 21:02:00 -0500
committerJack Nagel2014-05-27 21:03:47 -0500
commite55a116df68e22da6511b86f06edf65f829c26b7 (patch)
treec05f914a14cdf00955ed49f16f6b8f64242b13e2
parente8fbfad5de2d3ca8c2267c1799e5a2707f7a78cb (diff)
downloadhomebrew-e55a116df68e22da6511b86f06edf65f829c26b7.tar.bz2
Remove some evals from formula DSL
The default arguments were removed from these methods long ago, so nothing is standing in the way of using define_method here.
-rw-r--r--Library/Homebrew/formula.rb8
-rw-r--r--Library/Homebrew/resource.rb8
2 files changed, 4 insertions, 12 deletions
diff --git a/Library/Homebrew/formula.rb b/Library/Homebrew/formula.rb
index f0217bb74..19def4337 100644
--- a/Library/Homebrew/formula.rb
+++ b/Library/Homebrew/formula.rb
@@ -633,12 +633,8 @@ class Formula
stable.mirror(val)
end
- Checksum::TYPES.each do |cksum|
- class_eval <<-EOS, __FILE__, __LINE__ + 1
- def #{cksum}(val)
- stable.#{cksum}(val)
- end
- EOS
+ Checksum::TYPES.each do |type|
+ define_method(type) { |val| stable.send(type, val) }
end
def bottle *, &block
diff --git a/Library/Homebrew/resource.rb b/Library/Homebrew/resource.rb
index 4fabb33e3..6a72a6e99 100644
--- a/Library/Homebrew/resource.rb
+++ b/Library/Homebrew/resource.rb
@@ -95,12 +95,8 @@ class Resource
puts "For your reference the SHA1 is: #{fn.sha1}"
end
- Checksum::TYPES.each do |cksum|
- class_eval <<-EOS, __FILE__, __LINE__ + 1
- def #{cksum}(val)
- @checksum = Checksum.new(:#{cksum}, val)
- end
- EOS
+ Checksum::TYPES.each do |type|
+ define_method(type) { |val| @checksum = Checksum.new(type, val) }
end
def url val=nil, specs={}