aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMatt Di Pasquale2013-01-19 19:45:18 -0500
committerMike McQuaid2013-01-21 19:55:09 +0000
commite1c62c35465eb6149688c745e4309438c08c410b (patch)
tree233b5b78a670cb4c4f08c84e29140c575f8841d7
parent4f7ea00d5add1f9bba5a53c0e5909b8cc9dcf66a (diff)
downloadhomebrew-e1c62c35465eb6149688c745e4309438c08c410b.tar.bz2
brew upgrade: improve exit codes.
exit 1 if formulae given but none outdated Closes #17199. Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
-rw-r--r--Library/Homebrew/cmd/upgrade.rb7
1 files changed, 4 insertions, 3 deletions
diff --git a/Library/Homebrew/cmd/upgrade.rb b/Library/Homebrew/cmd/upgrade.rb
index c3a924ec5..6d477d6a8 100644
--- a/Library/Homebrew/cmd/upgrade.rb
+++ b/Library/Homebrew/cmd/upgrade.rb
@@ -16,11 +16,11 @@ module Homebrew extend self
Homebrew.perform_preinstall_checks
- outdated = if ARGV.named.empty?
+ if ARGV.named.empty?
require 'cmd/outdated'
- Homebrew.outdated_brews
+ outdated = Homebrew.outdated_brews
else
- ARGV.formulae.select do |f|
+ outdated = ARGV.formulae.select do |f|
if f.installed?
onoe "#{f}-#{f.installed_version} already installed"
elsif not f.rack.exist? or f.rack.children.empty?
@@ -29,6 +29,7 @@ module Homebrew extend self
true
end
end
+ exit 1 if outdated.empty?
end
# Expand the outdated list to include outdated dependencies then sort and