aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJack Nagel2014-07-10 12:38:09 -0500
committerJack Nagel2014-07-10 12:42:54 -0500
commitd6fd4dbb93d55a6f7951efd48a75432179464f9d (patch)
tree4c7c2846957b40f51ce770b6446be1a511332ef3
parent4f990ad298e2f6aa3b6c541f77c1396a58a6d3ee (diff)
downloadhomebrew-d6fd4dbb93d55a6f7951efd48a75432179464f9d.tar.bz2
Fix method signature
-rw-r--r--Library/Homebrew/patch.rb4
-rw-r--r--Library/Homebrew/test/test_patch.rb8
2 files changed, 6 insertions, 6 deletions
diff --git a/Library/Homebrew/patch.rb b/Library/Homebrew/patch.rb
index 04aade4f7..2b60a2e4d 100644
--- a/Library/Homebrew/patch.rb
+++ b/Library/Homebrew/patch.rb
@@ -3,8 +3,8 @@ require 'stringio'
require 'erb'
class Patch
- def self.create(strip, io=nil, &block)
- case strip ||= :p1
+ def self.create(strip, io, &block)
+ case strip
when :DATA, IO, StringIO
IOPatch.new(strip, :p1)
when String
diff --git a/Library/Homebrew/test/test_patch.rb b/Library/Homebrew/test/test_patch.rb
index 23ee84565..bc0e522d3 100644
--- a/Library/Homebrew/test/test_patch.rb
+++ b/Library/Homebrew/test/test_patch.rb
@@ -3,7 +3,7 @@ require 'patch'
class PatchTests < Homebrew::TestCase
def test_create_simple
- patch = Patch.create(:p2)
+ patch = Patch.create(:p2, nil)
assert_kind_of ExternalPatch, patch
assert_predicate patch, :external?
assert_equal :p2, patch.strip
@@ -17,7 +17,7 @@ class PatchTests < Homebrew::TestCase
end
def test_create_io_without_strip
- patch = Patch.create(StringIO.new("foo"))
+ patch = Patch.create(StringIO.new("foo"), nil)
assert_kind_of IOPatch, patch
assert_equal :p1, patch.strip
end
@@ -29,7 +29,7 @@ class PatchTests < Homebrew::TestCase
end
def test_create_string_without_strip
- patch = Patch.create("foo")
+ patch = Patch.create("foo", nil)
assert_kind_of IOPatch, patch
assert_equal :p1, patch.strip
end
@@ -41,7 +41,7 @@ class PatchTests < Homebrew::TestCase
end
def test_create_DATA_without_strip
- patch = Patch.create(:DATA)
+ patch = Patch.create(:DATA, nil)
assert_kind_of IOPatch, patch
assert_equal :p1, patch.strip
end