aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJack Nagel2013-10-02 22:01:09 -0500
committerJack Nagel2013-10-02 22:01:31 -0500
commitd4cea4f1b67bd299d49bba1182e5448b8b862180 (patch)
tree5e587f68fb964f1e313b211bed9678129dfe1e7a
parented40bfe497760fb86905dd5915040f9755d21b7c (diff)
downloadhomebrew-d4cea4f1b67bd299d49bba1182e5448b8b862180.tar.bz2
Pass the mktemp prefix as an argument
-rw-r--r--Library/Homebrew/extend/fileutils.rb10
-rw-r--r--Library/Homebrew/resource.rb2
2 files changed, 2 insertions, 10 deletions
diff --git a/Library/Homebrew/extend/fileutils.rb b/Library/Homebrew/extend/fileutils.rb
index 79a962fcb..9fb8c3878 100644
--- a/Library/Homebrew/extend/fileutils.rb
+++ b/Library/Homebrew/extend/fileutils.rb
@@ -5,15 +5,7 @@ module FileUtils extend self
# Create a temporary directory then yield. When the block returns,
# recursively delete the temporary directory.
- def mktemp
- # Prefer download_name if it is defined, for two reasons:
- # - The name attribute may be nil for resources that represent primary
- # formula downloads, in which case we want to use just the owner name.
- # - For resources that have a name defined, we want to use "owner--name"
- # instead of just "name"
- prefix = download_name if respond_to?(:download_name)
- prefix ||= name
-
+ def mktemp(prefix=name)
# I used /tmp rather than `mktemp -td` because that generates a directory
# name with exotic characters like + in it, and these break badly written
# scripts that don't escape strings before trying to regexp them :(
diff --git a/Library/Homebrew/resource.rb b/Library/Homebrew/resource.rb
index 55e5aa172..922fbfa59 100644
--- a/Library/Homebrew/resource.rb
+++ b/Library/Homebrew/resource.rb
@@ -50,7 +50,7 @@ class Resource
def stage(target=nil)
fetched = fetch
verify_download_integrity(fetched) if fetched.respond_to?(:file?) and fetched.file?
- mktemp do
+ mktemp(download_name) do
downloader.stage
if block_given?
yield self