diff options
| author | Jack Nagel | 2014-08-09 10:30:43 -0500 |
|---|---|---|
| committer | Jack Nagel | 2014-08-09 10:30:43 -0500 |
| commit | d3d2ed27902b3d8374dac283d501b0a19ad5b153 (patch) | |
| tree | 4ba9536868473ba69f0e007b8f0bd1a7c8e288e3 | |
| parent | 5dab3ee322a1fe8336d0fe7a7a7ee22467c982c7 (diff) | |
| download | homebrew-d3d2ed27902b3d8374dac283d501b0a19ad5b153.tar.bz2 | |
Stop duping options when duping the build object
The options collection cannot be mutated from the build object, so it
can be shared among copies safely.
| -rw-r--r-- | Library/Homebrew/build_options.rb | 2 | ||||
| -rw-r--r-- | Library/Homebrew/test/test_build_options.rb | 6 |
2 files changed, 0 insertions, 8 deletions
diff --git a/Library/Homebrew/build_options.rb b/Library/Homebrew/build_options.rb index 28fbb959c..b04c9dc1d 100644 --- a/Library/Homebrew/build_options.rb +++ b/Library/Homebrew/build_options.rb @@ -7,7 +7,6 @@ class BuildOptions attr_accessor :args attr_accessor :universal - attr_reader :options def initialize(args, options) @args = Options.coerce(args) @@ -16,7 +15,6 @@ class BuildOptions def initialize_copy(other) super - @options = other.options.dup @args = other.args.dup end diff --git a/Library/Homebrew/test/test_build_options.rb b/Library/Homebrew/test/test_build_options.rb index 11b3145ba..4fa332230 100644 --- a/Library/Homebrew/test/test_build_options.rb +++ b/Library/Homebrew/test/test_build_options.rb @@ -37,12 +37,6 @@ class BuildOptionsTests < Homebrew::TestCase assert_includes @build.unused_options, "--without-baz" end - def test_copies_do_not_share_underlying_options - orig = BuildOptions.new [], Options.new - copy = orig.dup - refute_same orig.options, copy.options - end - def test_copies_do_not_share_underlying_args orig = BuildOptions.new [], Options.new copy = orig.dup |