aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMike McQuaid2014-12-27 15:59:16 +0000
committerMike McQuaid2014-12-27 16:31:44 +0000
commitc2abfe89bbccf95c112b4883b26ffb5bee03889f (patch)
tree43b726d1b32ca0a75568509af74e1f120ab5e050
parent6aab0df960ed3d6b765b8be9aa077955e6e6ee93 (diff)
downloadhomebrew-c2abfe89bbccf95c112b4883b26ffb5bee03889f.tar.bz2
audit (strict): add require formula check.
-rw-r--r--Library/Homebrew/cmd/audit.rb5
1 files changed, 5 insertions, 0 deletions
diff --git a/Library/Homebrew/cmd/audit.rb b/Library/Homebrew/cmd/audit.rb
index 8c76d92a7..b2264be40 100644
--- a/Library/Homebrew/cmd/audit.rb
+++ b/Library/Homebrew/cmd/audit.rb
@@ -41,6 +41,7 @@ class FormulaText
@text = path.open("rb", &:read)
end
+
def without_patch
@text.split("\n__END__").first
end
@@ -565,6 +566,10 @@ class FormulaAuditor
good_quotes = bad_quotes.gsub "'", "\""
problem "use double-quotes for `#{good_quotes}` instead of `#{bad_quotes}`"
end
+
+ if line =~ /(require ["']formula["'])/
+ problem "`#{$1}` is now unnecessary"
+ end
end
end