aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAdam Vandenberg2010-09-07 09:23:29 -0700
committerAdam Vandenberg2010-09-07 09:23:29 -0700
commit8fcc3fcf4a80aa943ccac7e32f0bd397fed85a74 (patch)
treec23cee3a2bdfc041f5f38ca75a935cd8c59ead60
parentad09e7fefb79831657e13572cc3a58fc6d2ab8ec (diff)
downloadhomebrew-8fcc3fcf4a80aa943ccac7e32f0bd397fed85a74.tar.bz2
brew-audit: add check for git and fix warnings
-rwxr-xr-xLibrary/Contributions/examples/brew-audit.rb9
-rw-r--r--Library/Formula/guilt.rb2
2 files changed, 9 insertions, 2 deletions
diff --git a/Library/Contributions/examples/brew-audit.rb b/Library/Contributions/examples/brew-audit.rb
index b968ef327..666d52423 100755
--- a/Library/Contributions/examples/brew-audit.rb
+++ b/Library/Contributions/examples/brew-audit.rb
@@ -112,6 +112,15 @@ def audit_formula_instance f
problems << " * Dep #{d} is an alias; switch to the real name."
end
+ # Check for things we don't like to depend on.
+ # We allow non-Homebrew installs whenenever possible.
+ f.deps.each do |d|
+ case d
+ when "git"
+ problems << " * Don't use Git as a dependency; we allow non-Homebrew git installs."
+ end
+ end
+
# Google Code homepages should end in a slash
if f.homepage =~ %r[^https?://code\.google\.com/p/[^/]+[^/]$]
problems << " * Google Code homepage should end with a slash."
diff --git a/Library/Formula/guilt.rb b/Library/Formula/guilt.rb
index 34a1a0fe7..4822a3833 100644
--- a/Library/Formula/guilt.rb
+++ b/Library/Formula/guilt.rb
@@ -5,8 +5,6 @@ class Guilt <Formula
url 'http://www.kernel.org/pub/linux/kernel/people/jsipek/guilt/guilt-0.33.tar.bz2'
md5 'de2d3b82d3e08c8c6a940bd31f47d758'
- depends_on 'git'
-
def install
# Skip the documentation, it depends on xmlto.
system "make", "PREFIX=#{prefix}", "install"