diff options
| author | Dominyk Tiller | 2015-04-14 23:08:33 +0100 |
|---|---|---|
| committer | Mike McQuaid | 2015-04-14 22:37:56 -0700 |
| commit | 626ea622b3d17dab9fc5bbc962de3f047b97228f (patch) | |
| tree | 82ec5da7a32613936340ff04e4ff9473141c06c2 | |
| parent | ffaeb5ebda5ff66feb22d6c1520cacb48134a28b (diff) | |
| download | homebrew-626ea622b3d17dab9fc5bbc962de3f047b97228f.tar.bz2 | |
rubocop: update for 0.30.0
v0.30.0 has killed a couple of the methods being used and is throwing
warnings around like candy. This switches to the new methods.
Rubocops are obviously a matter of choice, and I’ve added choice here
based on what was said in previous PRs and my own personal views on
readability. Happy to be told to change things to different variables.
For upstream detail, see:
*
https://github.com/bbatsov/rubocop/blob/master/relnotes/v0.30.0.md#chang
es
* https://github.com/bbatsov/rubocop/pull/1721/files
* https://github.com/bbatsov/rubocop/pull/1655/files
Closes #38655.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
| -rw-r--r-- | Library/.rubocop.yml | 18 |
1 files changed, 8 insertions, 10 deletions
diff --git a/Library/.rubocop.yml b/Library/.rubocop.yml index 039f51d83..a3e2800eb 100644 --- a/Library/.rubocop.yml +++ b/Library/.rubocop.yml @@ -10,6 +10,14 @@ Style/StringLiterals: Style/StringLiteralsInInterpolation: EnforcedStyle: double_quotes +# percent-x is allowed for multiline +Style/CommandLiteral: + EnforcedStyle: mixed + +# paths abound, easy escape +Style/RegexpLiteral: + EnforcedStyle: slashes + # no metrics for formulas Metrics/AbcSize: Enabled: false @@ -48,10 +56,6 @@ Style/EmptyLineBetweenDefs: Style/NumericLiterals: Enabled: false -# paths abound, easy escape -Style/RegexpLiteral: - MaxSlashes: 0 - # consistency and readability when faced with string interpolation Style/PercentLiteralDelimiters: PreferredDelimiters: @@ -101,12 +105,6 @@ Style/WordArray: Style/UnneededCapitalW: Enabled: false -# percent-x is allowed for multiline -# TODO: enforce when rubocop has fixed this -# https://github.com/bbatsov/rubocop/issues/1397 -Style/UnneededPercentX: - Enabled: false - # TODO: rubocop bug regarding __END__ # see https://github.com/bbatsov/rubocop/issues/1541 Style/TrailingWhitespace: |