aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJack Nagel2014-04-02 19:58:15 -0500
committerJack Nagel2014-04-02 19:58:15 -0500
commit306959ba40954bec453c2232f7be63cbecd6ea0b (patch)
tree721f57f747798795f873a6e1b12235ddcad3bcd0
parent88f0fdf62804017c5d747fb9f5ed708f484f573b (diff)
downloadhomebrew-306959ba40954bec453c2232f7be63cbecd6ea0b.tar.bz2
Add fast path for CVS dep
The search mechanism in MacOS::Xcode is very slow. It requires shelling out at least twice, and possibly a third time (in the CLT-only case). Calling provides_cvs? activates this in order to determine the Xcode version. But if we know that there isn't an Xcode available for the current OS that meets the criteria, we can avoid this check entirely.
-rw-r--r--Library/Homebrew/dependency_collector.rb2
1 files changed, 1 insertions, 1 deletions
diff --git a/Library/Homebrew/dependency_collector.rb b/Library/Homebrew/dependency_collector.rb
index f0df90065..24214b188 100644
--- a/Library/Homebrew/dependency_collector.rb
+++ b/Library/Homebrew/dependency_collector.rb
@@ -170,7 +170,7 @@ class DependencyCollector
when strategy <= BazaarDownloadStrategy
Dependency.new("bazaar", tags)
when strategy <= CVSDownloadStrategy
- Dependency.new("cvs", tags) unless MacOS::Xcode.provides_cvs?
+ Dependency.new("cvs", tags) if MacOS.version >= :mavericks || !MacOS::Xcode.provides_cvs?
when strategy < AbstractDownloadStrategy
# allow unknown strategies to pass through
else