aws-sns-cli: pass strict audit, use https

Closes #36086.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>

1 files changed, 15 insertions, 11 deletions

diff --git a/Library/Formula/aws-sns-cli.rb b/Library/Formula/aws-sns-cli.rb
index 24412996f..69b167e46 100644
--- a/Library/Formula/aws-sns-cli.rb
+++ b/Library/Formula/aws-sns-cli.rb
@@ -1,25 +1,29 @@
-require 'formula'
-
 class AwsSnsCli < AmazonWebServicesFormula
-  homepage 'http://aws.amazon.com/developertools/3688'
-  url 'http://sns-public-resources.s3.amazonaws.com/SimpleNotificationServiceCli-2010-03-31.zip'
+  homepage "https://aws.amazon.com/developertools/3688"
+  url "https://sns-public-resources.s3.amazonaws.com/SimpleNotificationServiceCli-2010-03-31.zip"
   # The version in the tarball is the API version; this is the tool version
-  version '2013-09-27'
-  sha1 '192bd9e682f2b27a3c10f207f7a85c65dcaae471'
+  version "2013-09-27"
+  sha1 "192bd9e682f2b27a3c10f207f7a85c65dcaae471"
 
   def install
-    rm Dir['bin/*.cmd'] # Remove Windows versions
+    rm Dir["bin/*.cmd"] # Remove Windows versions
 
     # There is a "service" binary, which of course will conflict with any number
-    # other brews that have a generically named tool. So don't just blindly
+    # other brews that have a generically named tool. So don"t just blindly
     # install bin to the prefix.
-    jars = prefix/'jars'
+    jars = prefix/"jars"
     jars.install "bin", "lib"
-    system "chmod +x #{jars}/bin/*"
+    chmod 0755, Dir["#{jars}/bin/*"]
     bin.install_symlink Dir["#{jars}/bin/sns-*"]
   end
 
   def caveats
-    standard_instructions "AWS_SNS_HOME", prefix/'jars'
+    standard_instructions "AWS_SNS_HOME", prefix/"jars"
+  end
+
+  test do
+    ENV["JAVA_HOME"] = `/usr/libexec/java_home`.chomp
+    ENV["AWS_SNS_HOME"] = prefix/"jars"
+    assert_match /w.x.y.z/, shell_output("#{bin}/sns-version")
   end
 end