diff options
| author | Mark Christian | 2011-04-04 17:44:04 -0700 |
|---|---|---|
| committer | Mark Christian | 2011-04-04 17:44:04 -0700 |
| commit | 95a03fad9c5cfd25a684be3670bf5d1520d03456 (patch) | |
| tree | 1dd8ca7f93882e46c0cd63e88b791baab065127f | |
| parent | 130adca3d9aff23e8ba2e36b1ac23cfb1968432b (diff) | |
| download | ffffallback-95a03fad9c5cfd25a684be3670bf5d1520d03456.tar.bz2 | |
Various fixes, including only being able to expand the last dropdown
| -rw-r--r-- | bookmarklet/ffffallback.js | 22 | ||||
| -rw-r--r-- | secret.html | 9 |
2 files changed, 21 insertions, 10 deletions
diff --git a/bookmarklet/ffffallback.js b/bookmarklet/ffffallback.js index 47ac39d..354a127 100644 --- a/bookmarklet/ffffallback.js +++ b/bookmarklet/ffffallback.js @@ -318,15 +318,19 @@ fontClass = $.getClassForFont(font); row = $.createElementWithContent('li', '<b>' + font + '</b><input type="text" value="" placeholder="Fallback font" class="ffffallback-specify-font" data:font-class="' + fontClass + '" /><a href="#" class="ffffallback-disclosure"><span>▼</span></a><textarea class="ffffallback-more-values" placeholder="e.g. line-height: 1.75;"></textarea>'); row.setAttribute('class', 'collapsed'); - $.event(row.getElementsByClassName('ffffallback-disclosure')[0], 'click', function() { - if($.isClassOnElement('collapsed', row)) { - $.addClassToElement('expanded', row); - $.removeClassFromElement('collapsed', row); - } else { - $.addClassToElement('collapsed', row); - $.removeClassFromElement('expanded', row); - } - }); + + (function(row) { + $.event(row.getElementsByClassName('ffffallback-disclosure')[0], 'click', function() { + if($.isClassOnElement('collapsed', row)) { + $.addClassToElement('expanded', row); + $.removeClassFromElement('collapsed', row); + } else { + $.addClassToElement('collapsed', row); + $.removeClassFromElement('expanded', row); + } + }); + })(row); + fontList.appendChild(row); }); diff --git a/secret.html b/secret.html index 80b16a5..6e12aac 100644 --- a/secret.html +++ b/secret.html @@ -8,6 +8,10 @@ color:#444; font: normal normal normal 1em/1.5 'Helvetica Neue', Arial, Helvetica, sans-serif; } + + h2 { + font-family: 'lucida grande'; + } </style> </head> <body> @@ -19,6 +23,9 @@ <p>This is the bookmarklet: <a id="bookmarklet" href="#">ffffallback</a>—drag it to your bookmarks bar and brace yourself for an onslaught of unicorns and rainbows.</p> <script> var myURL = window.location.toString(); + if(myURL.indexOf('#') >= 0) { + myURL = myURL.split('#')[0]; + } var baseURL; if(myURL.match(/\.html$/)) { var urlChunks = myURL.split('/'); @@ -43,7 +50,7 @@ })();".replace(/\n/g, ' '); document.getElementById('bookmarklet').setAttribute('href', bookmarkletSource); - </script> + </script> <script type="text/javascript"> var _gaq = _gaq || []; |