diff options
| author | Tom Christie | 2013-06-05 13:45:28 +0100 | 
|---|---|---|
| committer | Tom Christie | 2013-06-05 13:45:28 +0100 | 
| commit | f8a0d31d71bf722741a472c27ae0a10ecbcbcec3 (patch) | |
| tree | a8cb76dbb0c62b17b779c0ee6ec68f334794821d /rest_framework | |
| parent | 2ca243a1144bb2a5461767a21ed14dec1d2b8dc2 (diff) | |
| download | django-rest-framework-f8a0d31d71bf722741a472c27ae0a10ecbcbcec3.tar.bz2 | |
Remove ConfigurationError in favor of Django's ImproperlyConfigured
Diffstat (limited to 'rest_framework')
| -rw-r--r-- | rest_framework/exceptions.py | 7 | ||||
| -rw-r--r-- | rest_framework/generics.py | 2 | ||||
| -rw-r--r-- | rest_framework/renderers.py | 4 | ||||
| -rw-r--r-- | rest_framework/throttling.py | 6 | 
4 files changed, 6 insertions, 13 deletions
| diff --git a/rest_framework/exceptions.py b/rest_framework/exceptions.py index 0c96ecdd..425a7214 100644 --- a/rest_framework/exceptions.py +++ b/rest_framework/exceptions.py @@ -86,10 +86,3 @@ class Throttled(APIException):              self.detail = format % (self.wait, self.wait != 1 and 's' or '')          else:              self.detail = detail or self.default_detail - - -class ConfigurationError(Exception): -    """ -    Indicates an internal server error. -    """ -    pass diff --git a/rest_framework/generics.py b/rest_framework/generics.py index 9ccc7898..80efad01 100644 --- a/rest_framework/generics.py +++ b/rest_framework/generics.py @@ -285,7 +285,7 @@ class GenericAPIView(views.APIView):              )              filter_kwargs = {self.slug_field: slug}          else: -            raise exceptions.ConfigurationError( +            raise ImproperlyConfigured(                  'Expected view %s to be called with a URL keyword argument '                  'named "%s". Fix your URL conf, or set the `.lookup_field` '                  'attribute on the view correctly.' % diff --git a/rest_framework/renderers.py b/rest_framework/renderers.py index b2fe43ea..8b2428ad 100644 --- a/rest_framework/renderers.py +++ b/rest_framework/renderers.py @@ -11,6 +11,7 @@ from __future__ import unicode_literals  import copy  import json  from django import forms +from django.core.exceptions import ImproperlyConfigured  from django.http.multipartparser import parse_header  from django.template import RequestContext, loader, Template  from django.utils.xmlutils import SimplerXMLGenerator @@ -18,7 +19,6 @@ from rest_framework.compat import StringIO  from rest_framework.compat import six  from rest_framework.compat import smart_text  from rest_framework.compat import yaml -from rest_framework.exceptions import ConfigurationError  from rest_framework.settings import api_settings  from rest_framework.request import clone_request  from rest_framework.utils import encoders @@ -270,7 +270,7 @@ class TemplateHTMLRenderer(BaseRenderer):              return [self.template_name]          elif hasattr(view, 'get_template_names'):              return view.get_template_names() -        raise ConfigurationError('Returned a template response with no template_name') +        raise ImproperlyConfigured('Returned a template response with no template_name')      def get_exception_template(self, response):          template_names = [name % {'status_code': response.status_code} diff --git a/rest_framework/throttling.py b/rest_framework/throttling.py index 93ea9816..9d89d1cb 100644 --- a/rest_framework/throttling.py +++ b/rest_framework/throttling.py @@ -3,7 +3,7 @@ Provides various throttling policies.  """  from __future__ import unicode_literals  from django.core.cache import cache -from rest_framework import exceptions +from django.core.exceptions import ImproperlyConfigured  from rest_framework.settings import api_settings  import time @@ -65,13 +65,13 @@ class SimpleRateThrottle(BaseThrottle):          if not getattr(self, 'scope', None):              msg = ("You must set either `.scope` or `.rate` for '%s' throttle" %                     self.__class__.__name__) -            raise exceptions.ConfigurationError(msg) +            raise ImproperlyConfigured(msg)          try:              return self.settings.DEFAULT_THROTTLE_RATES[self.scope]          except KeyError:              msg = "No default throttle rate set for '%s' scope" % self.scope -            raise exceptions.ConfigurationError(msg) +            raise ImproperlyConfigured(msg)      def parse_rate(self, rate):          """ | 
