diff options
| author | Tom Christie | 2013-09-20 05:34:57 -0700 |
|---|---|---|
| committer | Tom Christie | 2013-09-20 05:34:57 -0700 |
| commit | d9a8bc08929de0163b8fbb87dc9a3af685330eaf (patch) | |
| tree | ecd8761fce74c0a86d98187accd4377b95adddbb /rest_framework/tests | |
| parent | eb0a98ad4b031be5742b5d257b847404c2e5249b (diff) | |
| parent | b82c44af48f25c0a60880b8d702caf6a74d80baa (diff) | |
| download | django-rest-framework-d9a8bc08929de0163b8fbb87dc9a3af685330eaf.tar.bz2 | |
Merge pull request #1117 from carltongibson/#1116
Clear cached serializer data on `save()` + test. Fixes #1116.
Diffstat (limited to 'rest_framework/tests')
| -rw-r--r-- | rest_framework/tests/test_serializer.py | 16 |
1 files changed, 16 insertions, 0 deletions
diff --git a/rest_framework/tests/test_serializer.py b/rest_framework/tests/test_serializer.py index c2497660..8d246b01 100644 --- a/rest_framework/tests/test_serializer.py +++ b/rest_framework/tests/test_serializer.py @@ -1,3 +1,4 @@ +# -*- coding: utf-8 -*- from __future__ import unicode_literals from django.db import models from django.db.models.fields import BLANK_CHOICE_DASH @@ -136,6 +137,7 @@ class BasicTests(TestCase): 'Happy new year!', datetime.datetime(2012, 1, 1) ) + self.actionitem = ActionItem(title='Some to do item',) self.data = { 'email': 'tom@example.com', 'content': 'Happy new year!', @@ -264,6 +266,20 @@ class BasicTests(TestCase): """ self.assertRaises(AssertionError, PersonSerializerInvalidReadOnly, []) + def test_serializer_data_is_cleared_on_save(self): + """ + Check _data attribute is cleared on `save()` + + Regression test for #1116 + — id field is not populated if `data` is accessed prior to `save()` + """ + serializer = ActionItemSerializer(self.actionitem) + self.assertIsNone(serializer.data.get('id',None), 'New instance. `id` should not be set.') + serializer.save() + self.assertIsNotNone(serializer.data.get('id',None), 'Model is saved. `id` should be set.') + + + class DictStyleSerializer(serializers.Serializer): """ |
