aboutsummaryrefslogtreecommitdiffstats
path: root/rest_framework/tests/relations.py
diff options
context:
space:
mode:
authorTom Christie2013-01-04 13:50:40 +0000
committerTom Christie2013-01-04 13:50:40 +0000
commiteb14278a3b08247c0aff5b2338a98203b51728c3 (patch)
treea7ee5329f62b57d34c8e7de9f9bc73e35ec42896 /rest_framework/tests/relations.py
parent4c86fd46d772e1fd3789d9ed2a76b9b92cce0872 (diff)
downloaddjango-rest-framework-eb14278a3b08247c0aff5b2338a98203b51728c3.tar.bz2
Add proper validation for updating relational fields with incorrect types. Fixes #446.
Diffstat (limited to 'rest_framework/tests/relations.py')
-rw-r--r--rest_framework/tests/relations.py13
1 files changed, 12 insertions, 1 deletions
diff --git a/rest_framework/tests/relations.py b/rest_framework/tests/relations.py
index 108ec473..91daea8a 100644
--- a/rest_framework/tests/relations.py
+++ b/rest_framework/tests/relations.py
@@ -19,4 +19,15 @@ class FieldTests(TestCase):
https://github.com/tomchristie/django-rest-framework/issues/446
"""
field = serializers.PrimaryKeyRelatedField(queryset=NullModel.objects.all())
- self.assertRaises(serializers.ValidationError, field.from_native, ('',))
+ self.assertRaises(serializers.ValidationError, field.from_native, '')
+ self.assertRaises(serializers.ValidationError, field.from_native, [])
+
+ def test_hyperlinked_related_field_with_empty_string(self):
+ field = serializers.HyperlinkedRelatedField(queryset=NullModel.objects.all(), view_name='')
+ self.assertRaises(serializers.ValidationError, field.from_native, '')
+ self.assertRaises(serializers.ValidationError, field.from_native, [])
+
+ def test_slug_related_field_with_empty_string(self):
+ field = serializers.SlugRelatedField(queryset=NullModel.objects.all(), slug_field='pk')
+ self.assertRaises(serializers.ValidationError, field.from_native, '')
+ self.assertRaises(serializers.ValidationError, field.from_native, [])