diff options
| author | Tom Christie | 2014-12-03 23:01:30 +0000 | 
|---|---|---|
| committer | Tom Christie | 2014-12-03 23:01:30 +0000 | 
| commit | f221b737a1c329277ac90b8e2049882e0dde3e6f (patch) | |
| tree | 6dd91eefeb5f8e18a3e3aae5a575e134d368a28d /rest_framework/serializers.py | |
| parent | 66bce38b5902872435038dd0d387f64cb4156ee4 (diff) | |
| parent | ab25d706c78627dfd582fe9d142ada510c4d6d90 (diff) | |
| download | django-rest-framework-f221b737a1c329277ac90b8e2049882e0dde3e6f.tar.bz2 | |
Merge pull request #2197 from mtschammer/mtschammer-validated_attrs-rename
Renamed validated_attrs to validated_data to be more in line with other code
Diffstat (limited to 'rest_framework/serializers.py')
| -rw-r--r-- | rest_framework/serializers.py | 20 | 
1 files changed, 10 insertions, 10 deletions
| diff --git a/rest_framework/serializers.py b/rest_framework/serializers.py index c7f04b40..af8aeb48 100644 --- a/rest_framework/serializers.py +++ b/rest_framework/serializers.py @@ -608,20 +608,20 @@ class ModelSerializer(Serializer):      })      _related_class = PrimaryKeyRelatedField -    def create(self, validated_attrs): +    def create(self, validated_data):          """          We have a bit of extra checking around this in order to provide          descriptive messages when something goes wrong, but this method is          essentially just: -            return ExampleModel.objects.create(**validated_attrs) +            return ExampleModel.objects.create(**validated_data)          If there are many to many fields present on the instance then they          cannot be set until the model is instantiated, in which case the          implementation is like so: -            example_relationship = validated_attrs.pop('example_relationship') -            instance = ExampleModel.objects.create(**validated_attrs) +            example_relationship = validated_data.pop('example_relationship') +            instance = ExampleModel.objects.create(**validated_data)              instance.example_relationship = example_relationship              return instance @@ -644,17 +644,17 @@ class ModelSerializer(Serializer):          ModelClass = self.Meta.model -        # Remove many-to-many relationships from validated_attrs. +        # Remove many-to-many relationships from validated_data.          # They are not valid arguments to the default `.create()` method,          # as they require that the instance has already been saved.          info = model_meta.get_field_info(ModelClass)          many_to_many = {}          for field_name, relation_info in info.relations.items(): -            if relation_info.to_many and (field_name in validated_attrs): -                many_to_many[field_name] = validated_attrs.pop(field_name) +            if relation_info.to_many and (field_name in validated_data): +                many_to_many[field_name] = validated_data.pop(field_name)          try: -            instance = ModelClass.objects.create(**validated_attrs) +            instance = ModelClass.objects.create(**validated_data)          except TypeError as exc:              msg = (                  'Got a `TypeError` when calling `%s.objects.create()`. ' @@ -679,7 +679,7 @@ class ModelSerializer(Serializer):          return instance -    def update(self, instance, validated_attrs): +    def update(self, instance, validated_data):          assert not any(              isinstance(field, BaseSerializer) and (key in validated_attrs)              for key, field in self.fields.items() @@ -690,7 +690,7 @@ class ModelSerializer(Serializer):              (self.__class__.__module__, self.__class__.__name__)          ) -        for attr, value in validated_attrs.items(): +        for attr, value in validated_data.items():              setattr(instance, attr, value)          instance.save()          return instance | 
