Fix rendering of forms and add error rendering on HTML form

1 files changed, 13 insertions, 13 deletions

diff --git a/rest_framework/serializers.py b/rest_framework/serializers.py
index 206a8123..bc9f73d1 100644
--- a/rest_framework/serializers.py
+++ b/rest_framework/serializers.py
@@ -308,24 +308,14 @@ class BaseSerializer(WritableField):
         """
         ret = self._dict_class()
         ret.fields = self._dict_class()
-        ret.empty = obj is None
 
         for field_name, field in self.fields.items():
             field.initialize(parent=self, field_name=field_name)
             key = self.get_field_key(field_name)
-            if self._errors:
-                value = self.init_data.get(field_name)
-            else:
-                value = field.field_to_native(obj, field_name)
-
-            field._errors = self._errors.get(key) if self._errors else None
-            field._name = field_name
-            field._value = value
-            if not field.label:
-                field.label = pretty_name(key)
-
+            value = field.field_to_native(obj, field_name)
             ret[key] = value
-            ret.fields[key] = field
+            ret.fields[key] = self.augment_field(field, field_name, key, value)
+
         return ret
 
     def from_native(self, data, files):
@@ -333,6 +323,7 @@ class BaseSerializer(WritableField):
         Deserialize primitives -> objects.
         """
         self._errors = {}
+
         if data is not None or files is not None:
             attrs = self.restore_fields(data, files)
             if attrs is not None:
@@ -343,6 +334,15 @@ class BaseSerializer(WritableField):
         if not self._errors:
             return self.restore_object(attrs, instance=getattr(self, 'object', None))
 
+    def augment_field(self, field, field_name, key, value):
+        # This horrible stuff is to manage serializers rendering to HTML
+        field._errors = self._errors.get(key) if self._errors else None
+        field._name = field_name
+        field._value = self.init_data.get(key) if self._errors and self.init_data else value
+        if not field.label:
+            field.label = pretty_name(key)
+        return field
+
     def field_to_native(self, obj, field_name):
         """
         Override default so that the serializer can be used as a nested field