diff options
| author | Tom Christie | 2013-05-05 16:47:45 +0100 | 
|---|---|---|
| committer | Tom Christie | 2013-05-05 16:47:45 +0100 | 
| commit | 538d2e35e7f1e4623a215d1b8c684b284f951c09 (patch) | |
| tree | ed51e64d85637c8183f407d99695e9eb08abee79 /rest_framework/relations.py | |
| parent | 2d44dc3f5490e93147ecedbd33b03f41a598b43a (diff) | |
| download | django-rest-framework-538d2e35e7f1e4623a215d1b8c684b284f951c09.tar.bz2 | |
lookup_field on hyperlink serializers
Diffstat (limited to 'rest_framework/relations.py')
| -rw-r--r-- | rest_framework/relations.py | 10 | 
1 files changed, 9 insertions, 1 deletions
| diff --git a/rest_framework/relations.py b/rest_framework/relations.py index bc7f112c..fc5054b2 100644 --- a/rest_framework/relations.py +++ b/rest_framework/relations.py @@ -360,7 +360,15 @@ class HyperlinkedRelatedField(RelatedField):              # Only try slug if it corresponds to an attribute on the object.              kwargs = {self.slug_url_kwarg: slug}              try: -                return reverse(view_name, kwargs=kwargs, request=request, format=format) +                ret = reverse(view_name, kwargs=kwargs, request=request, format=format) +                if self.slug_field == 'slug' and self.slug_url_kwarg == 'slug': +                    # If the lookup succeeds using the default slug params, +                    # then `slug_field` is being used implicitly, and we +                    # we need to warn about the pending deprecation. +                    msg = 'Implicit slug field hyperlinked fields are pending deprecation.' \ +                          'You should set `lookup_field=slug` on the HyperlinkedRelatedField.' +                    warnings.warn(msg, PendingDeprecationWarning, stacklevel=2) +                return ret              except NoReverseMatch:                  pass | 
