diff options
| author | Tom Christie | 2013-01-02 13:47:58 +0000 |
|---|---|---|
| committer | Tom Christie | 2013-01-02 13:47:58 +0000 |
| commit | 438c2cac1bcd5ac24ea83bc75deb12b8584b906a (patch) | |
| tree | ebd6727f2d95813f3e6efd4de07a7027e236ef31 /rest_framework/mixins.py | |
| parent | d379997aba5b1e41309bbed8740ed704c0feb58b (diff) | |
| parent | ef73160599ef836f47801fe550168ecdaa3e20d6 (diff) | |
| download | django-rest-framework-438c2cac1bcd5ac24ea83bc75deb12b8584b906a.tar.bz2 | |
Merge branch 'patch'
Diffstat (limited to 'rest_framework/mixins.py')
| -rw-r--r-- | rest_framework/mixins.py | 19 |
1 files changed, 12 insertions, 7 deletions
diff --git a/rest_framework/mixins.py b/rest_framework/mixins.py index 2700606d..43581ae9 100644 --- a/rest_framework/mixins.py +++ b/rest_framework/mixins.py @@ -16,11 +16,14 @@ class CreateModelMixin(object): """ def create(self, request, *args, **kwargs): serializer = self.get_serializer(data=request.DATA, files=request.FILES) + if serializer.is_valid(): self.pre_save(serializer.object) self.object = serializer.save() headers = self.get_success_headers(serializer.data) - return Response(serializer.data, status=status.HTTP_201_CREATED, headers=headers) + return Response(serializer.data, status=status.HTTP_201_CREATED, + headers=headers) + return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST) def get_success_headers(self, data): @@ -82,20 +85,21 @@ class UpdateModelMixin(object): Should be mixed in with `SingleObjectBaseView`. """ def update(self, request, *args, **kwargs): + partial = kwargs.pop('partial', False) try: self.object = self.get_object() - created = False + success_status_code = status.HTTP_200_OK except Http404: self.object = None - created = True + success_status_code = status.HTTP_201_CREATED - serializer = self.get_serializer(self.object, data=request.DATA, files=request.FILES) + serializer = self.get_serializer(self.object, data=request.DATA, + files=request.FILES, partial=partial) if serializer.is_valid(): self.pre_save(serializer.object) self.object = serializer.save() - status_code = created and status.HTTP_201_CREATED or status.HTTP_200_OK - return Response(serializer.data, status=status_code) + return Response(serializer.data, status=success_status_code) return Response(serializer.errors, status=status.HTTP_400_BAD_REQUEST) @@ -115,7 +119,8 @@ class UpdateModelMixin(object): # Ensure we clean the attributes so that we don't eg return integer # pk using a string representation, as provided by the url conf kwarg. - obj.full_clean() + if hasattr(obj, 'full_clean'): + obj.full_clean() class DestroyModelMixin(object): |
