aboutsummaryrefslogtreecommitdiffstats
path: root/djangorestframework/mixins.py
diff options
context:
space:
mode:
authorJamie Matthews2012-01-05 14:07:31 +0000
committerJamie Matthews2012-01-05 14:07:31 +0000
commit18535c7a387731b0e290ff59bb604bfd1a275ccc (patch)
tree0c0aeefd5c12b065f13ec3a58f8a79092de8c422 /djangorestframework/mixins.py
parentb745d0c2f46b901ed7a6b8e92d4ea3faf2a47736 (diff)
downloaddjango-rest-framework-18535c7a387731b0e290ff59bb604bfd1a275ccc.tar.bz2
Preserve existing query params in PaginatorMixin
Previously, generation of next/previous links would discard any existing query parameters. This commit introduces a dependency on URLObject, which is used to intelligently parse and modify URLs to ensure existing params are preserved. Addresses issues #107
Diffstat (limited to 'djangorestframework/mixins.py')
-rw-r--r--djangorestframework/mixins.py6
1 files changed, 4 insertions, 2 deletions
diff --git a/djangorestframework/mixins.py b/djangorestframework/mixins.py
index b1a634a0..e01de3fc 100644
--- a/djangorestframework/mixins.py
+++ b/djangorestframework/mixins.py
@@ -7,6 +7,7 @@ from django.contrib.auth.models import AnonymousUser
from django.core.paginator import Paginator
from django.db.models.fields.related import ForeignKey
from django.http import HttpResponse
+from urlobject import URLObject
from djangorestframework import status
from djangorestframework.renderers import BaseRenderer
@@ -659,11 +660,12 @@ class PaginatorMixin(object):
def url_with_page_number(self, page_number):
""" Constructs a url used for getting the next/previous urls """
- url = "%s?page=%d" % (self.request.path, page_number)
+ url = URLObject.parse(self.request.get_full_path())
+ url = url.add_query_param('page', page_number)
limit = self.get_limit()
if limit != self.limit:
- url = "%s&limit=%d" % (url, limit)
+ url = url.add_query_param('limit', limit)
return url