aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMarko Tibold2012-09-08 18:18:05 +0200
committerMarko Tibold2012-09-08 18:18:05 +0200
commit024780a974eed66a45f27f27cfbec28bd1432d07 (patch)
tree22605c7dbe253ae7c77a56fbe93a54d1655b8ea0
parent274420c658b406ba27c58c4a66f4c8261ce91b4f (diff)
downloaddjango-rest-framework-024780a974eed66a45f27f27cfbec28bd1432d07.tar.bz2
Fields are showing up again. Still WIP.
-rw-r--r--djangorestframework/renderers.py45
-rw-r--r--djangorestframework/templates/djangorestframework/base.html5
2 files changed, 20 insertions, 30 deletions
diff --git a/djangorestframework/renderers.py b/djangorestframework/renderers.py
index 4f8225b1..4a14d5ee 100644
--- a/djangorestframework/renderers.py
+++ b/djangorestframework/renderers.py
@@ -16,6 +16,7 @@ from djangorestframework.utils import encoders
from djangorestframework.utils.breadcrumbs import get_breadcrumbs
from djangorestframework.utils.mediatypes import get_media_type_params, add_media_type_param, media_type_matches
from djangorestframework import VERSION
+from djangorestframework.fields import FloatField, IntegerField, DateTimeField, DateField, EmailField, CharField, BooleanField
import string
@@ -234,32 +235,24 @@ class DocumentingTemplateRenderer(BaseRenderer):
provide a form that can be used to submit arbitrary content.
"""
- # Get the form instance if we have one bound to the input
- form_instance = None
- if method == getattr(view, 'method', view.request.method).lower():
- form_instance = getattr(view, 'bound_form_instance', None)
-
- if not form_instance and hasattr(view, 'get_bound_form'):
- # Otherwise if we have a response that is valid against the form then use that
- if view.response.has_content_body:
- try:
- form_instance = view.get_bound_form(view.response.cleaned_content, method=method)
- if form_instance and not form_instance.is_valid():
- form_instance = None
- except Exception:
- form_instance = None
-
- # If we still don't have a form instance then try to get an unbound form
- if not form_instance:
- try:
- form_instance = view.get_bound_form(method=method)
- except Exception:
- pass
-
- # If we still don't have a form instance then try to get an unbound form which can tunnel arbitrary content types
- if not form_instance:
- form_instance = self._get_generic_content_form(view)
-
+ # We need to map our Fields to Django's Fields.
+ field_mapping = dict([
+ [FloatField.__name__, forms.FloatField],
+ [IntegerField.__name__, forms.IntegerField],
+ [DateTimeField.__name__, forms.DateTimeField],
+ [DateField.__name__, forms.DateField],
+ [EmailField.__name__, forms.EmailField],
+ [CharField.__name__, forms.CharField],
+ [BooleanField.__name__, forms.BooleanField]
+ ])
+
+ # Creating an on the fly form see: http://stackoverflow.com/questions/3915024/dynamically-creating-classes-python
+ fields = {}
+ for k, v in self.view.get_serializer().fields.items():
+ fields[k] = field_mapping[v.__class__.__name__]()
+ OnTheFlyForm = type("OnTheFlyForm", (forms.Form,), fields)
+
+ form_instance = OnTheFlyForm(self.view.get_serializer().data)
return form_instance
def _get_generic_content_form(self, view):
diff --git a/djangorestframework/templates/djangorestframework/base.html b/djangorestframework/templates/djangorestframework/base.html
index d33c5393..97e81bbe 100644
--- a/djangorestframework/templates/djangorestframework/base.html
+++ b/djangorestframework/templates/djangorestframework/base.html
@@ -78,8 +78,6 @@
</form>
{% endif %}
- {% comment %}
- DROP POST/PUT/DELETE until the forms are working with REST framework 2
{# Only display the POST/PUT/DELETE forms if method tunneling via POST forms is enabled and the user has permissions on this view. #}
{% if response.status_code != 403 %}
@@ -90,7 +88,7 @@
<h2>POST {{ name }}</h2>
{% csrf_token %}
{{ post_form.non_field_errors }}
- {% for field in post_form %}
+ {% for field in post_form %}
<div class='form-row'>
{{ field.label_tag }}
{{ field }}
@@ -141,7 +139,6 @@
{% endif %}
{% endif %}
- {% endcomment %}
</div>
<!-- END content-main -->