Normalize the way we write panel tests.

1 files changed, 16 insertions, 15 deletions

diff --git a/tests/panels/test_sql.py b/tests/panels/test_sql.py
index 4acd10b..6b14b68 100644
--- a/tests/panels/test_sql.py
+++ b/tests/panels/test_sql.py
@@ -15,15 +15,18 @@ from ..base import BaseTestCase
 
 class SQLPanelTestCase(BaseTestCase):
 
+    def setUp(self):
+        super(SQLPanelTestCase, self).setUp()
+        self.panel = self.toolbar.get_panel(SQLDebugPanel)
+
     def test_recording(self):
-        panel = self.toolbar.get_panel(SQLDebugPanel)
-        self.assertEqual(len(panel._queries), 0)
+        self.assertEqual(len(self.panel._queries), 0)
 
         list(User.objects.all())
 
         # ensure query was logged
-        self.assertEqual(len(panel._queries), 1)
-        query = panel._queries[0]
+        self.assertEqual(len(self.panel._queries), 1)
+        query = self.panel._queries[0]
         self.assertEqual(query[0], 'default')
         self.assertTrue('sql' in query[1])
         self.assertTrue('duration' in query[1])
@@ -33,25 +36,24 @@ class SQLPanelTestCase(BaseTestCase):
         self.assertTrue(len(query[1]['stacktrace']) > 0)
 
     def test_non_ascii_query(self):
-        panel = self.toolbar.get_panel(SQLDebugPanel)
-        self.assertEqual(len(panel._queries), 0)
+        self.assertEqual(len(self.panel._queries), 0)
 
         # non-ASCII text query
         list(User.objects.extra(where=["username = 'apéro'"]))
-        self.assertEqual(len(panel._queries), 1)
+        self.assertEqual(len(self.panel._queries), 1)
 
         # non-ASCII text parameters
         list(User.objects.filter(username='thé'))
-        self.assertEqual(len(panel._queries), 2)
+        self.assertEqual(len(self.panel._queries), 2)
 
         # non-ASCII bytes parameters
         list(User.objects.filter(username='café'.encode('utf-8')))
-        self.assertEqual(len(panel._queries), 3)
+        self.assertEqual(len(self.panel._queries), 3)
 
-        panel.process_response(self.request, self.response)
+        self.panel.process_response(self.request, self.response)
 
         # ensure the panel renders correctly
-        self.assertIn('café', panel.content())
+        self.assertIn('café', self.panel.content())
 
     @unittest.skipUnless(connection.vendor == 'postgresql',
                          'Test valid only on PostgreSQL')
@@ -65,15 +67,14 @@ class SQLPanelTestCase(BaseTestCase):
             self.assertTrue('erroneous query' in str(e))
 
     def test_disable_stacktraces(self):
-        panel = self.toolbar.get_panel(SQLDebugPanel)
-        self.assertEqual(len(panel._queries), 0)
+        self.assertEqual(len(self.panel._queries), 0)
 
         with self.settings(DEBUG_TOOLBAR_CONFIG={'ENABLE_STACKTRACES': False}):
             list(User.objects.all())
 
         # ensure query was logged
-        self.assertEqual(len(panel._queries), 1)
-        query = panel._queries[0]
+        self.assertEqual(len(self.panel._queries), 1)
+        query = self.panel._queries[0]
         self.assertEqual(query[0], 'default')
         self.assertTrue('sql' in query[1])
         self.assertTrue('duration' in query[1])