| Age | Commit message (Collapse) | Author |
|---|
|
|
|
Disable the checkboxes next to pending referentials. This prevents them
from being deleted by the batch deletion operation.
In general it seems like we shouldn't be operating on pending
referentials, so if any new batch actions are added, it would make sense
to me for the checkboxes to stay disabled.
We want to disallow deletion of pending referentials because this can
put the data in an inconsistent state that requires manual intervention
to clean (I think).
Refs #6858
|
|
|
|
|
|
|
|
|
|
Infer it when possible, and use a nested otherwise
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Update the view to match the actual controller behaviour.
|
|
- verifying the visibility of the action box
- no dynamic behavior of the action box is verified (yet?) - would need javascript execution
- refactoring suggestions --> https://projects.af83.io/issues/5206
|
|
|
|
|
|
Refs #4741
|
|
|
|
|
|
- Add some context to referential and workbench decorator to access current_referential and assign it to the cloned referential
- Add a build_referential method to avoir duplicates of code (in the controller and in the model), need to clean a bit more
- Need to add some Spec features to take into account the functional scope of the current_user
|
|
Calendar#index date filter (ransackable scope)
I realized that we could submit the form with incomplete date which caused an 500 error.
So I added a small JS script to prevent user from subnitting filter form with incomplete dates
Since it was really similar with previous work I added two folders : /helpers & /filters to be more DRY
The JS files are loaded in 4 views for the moment, hence the update in the assets.rb file
|
|
Added params to certains paths to have the workbench_id in it.
The goal is to have the current workbench_id to assign it when do a Referential#new_from
Then I finished the use of the functional scope to avoid potential errors
I skipped some tests that hve a #TODO so we can easily find them
|
|
Testing out the new `TableBuilderHelper::Column#link_to` method to
provide the link needed to go to the row object's #show page.
Seems to work in this context, which is promising!
|
|
|
|
|
|
|
|
|
|
|
|
Keep the helper code globally the same.
Changes:
* Remove `if action == :edit` since we never execute that branch. In
fact, the only place we ever use the multiple selection toolbox in
conjunction with the table builder is on Workbenches#show, and that
page only uses a :delete action.
* Rename `dPath` to be clearer
* Add some whitespace to improve readability
* Rename `actitem` to `action_link` for better readability
* Connect the links and label with `#+` instead of `#concat`
Add the toolbox to "workbenches/show.html.slim" to get the page looking
like it was before I changed the table builder.
Needed to wrap the table and toolbox in a `<div class="select_table">`
in order for the JavaScript part of it to work (otherwise selection
wouldn't activate the link, and likely other stuff would be messed up
too).
Now that the table builder and the selection toolbox are separate, it
makes sense to put the "select_table" `<div>` in the template.
Refs #3479
|
|
Now that we have the [:archive, :unarchive, :delete] links present in
`ReferentialDecorator#action_links`, we don't need to include them here.
Otherwise the links are duplicated between the custom links defined here
and those that come from the `ReferentialDecorator`.
Refs #3479
|
|
Use our new column syntax to build the table, creating
`TableBuilderHelper::Column` objects for each column. This gets our
table rendering again with the new `table_builder_2` code.
Remove the old table builder code as we're going to switch entirely to
this one.
Get rid of the TODO about the =>s as it's no longer relevant.
Refs #3479
|
|
I had coded this the opposite of what it should have been. Instead, if
`selectable` is true, we should show the selection checkboxes.
Invert the conditions and add `selectable: true` to the
`table_builder_2` calls that expect a checkbox column.
Also remove the TODO because this argument is necessary.
Refs #3479
|
|
Use this page as a visual testing ground for the new table builder.
Currently just verifying that nothing obvious changes visually.
Eventually we'll convert this page for real, but the API for the updated
table builder isn't finalised yet.
Refs #3479
|
|
|
|
|
|
|
|
|
|
|
|
|
|
design sources
|
|
|
|
|
|
|
|
|
|
|
|
|
|
(first pass)
|
|
|
|
|
