| Age | Commit message (Collapse) | Author |
|---|
|
|
|
along with the React interface
|
|
|
|
|
|
|
|
|
|
|
|
af83/5574-vehicle-journeys--fix-transporter-deletion-in-modal--rb
5574 vehicle journeys fix transporter deletion in modal rb
|
|
While the 'x' button in the Select2 was available in the 'edit' modal
for a vehicle journey, it was not in the 'add' modal. Thus, once you
added an associated company, you couldn't remove it in the modal. You'd
either have to cancel and create your vehicle journey again, or create
it an delete the company in the 'edit' modal later.
This enables the 'x' button in the 'add' modal (it previously was only
enabled when `editMode` was active) and sets the proper action/reducer
to remove the company.
The `allowClear` attribute was changed to only work in the 'edit' modal
in 0079238842263768b88b0fa0fd977824b49eabd5. That commit appears to be
changing things so that certain functions work when not in 'edit' mode.
The case we're concerned about is that the 'edit' modal can be opened
when in 'view' mode (not 'edit' mode) in order to get more detailed
information about a vehicle journey. This means the company Select2 is
available in 'view' mode, and the 'x' button should not be visible in
that case. But, when I tested this, even with `allowClear: true`, the
'x' button wasn't visible. This, I can only assume, is because the
Select2 is in a 'disabled' state, so it's smart enough to know not to
show the 'x' button. Which works great for us, because this allows us to
not show the 'x' button here and still show it in the 'add' and 'edit'
modals.
Refs #5574
|
|
Ensure a time is set for all non-commercial stops
|
|
And Refactor the component in the process
|
|
When the number of possible values is low (<10), display the values
right away, don't use an Ajax query
|
|
|
|
:fire: useless code
Rename some vars
|
|
- Add most of the react code
- And the specs where possible
Still remains:
- Link PurchaseWindows to VehicleJourneys in the model
- Add an autocompletion endpoint
|
|
Show the tools buttons even if editMode = false
The only buttons activated (if a vj is selected) are info, timetable and notes
We then change the behaviour of the modals depending ont the context (editMode or note)
|
|
|
