| Age | Commit message (Collapse) | Author |
|
And fix a bug preventing the deletion of referentials without a schema
|
|
|
|
|
|
doing so
I also changed the way 403 errors are handled, to properly respond with
a 403 HTTP code
|
|
Infer it when possible, and use a nested otherwise
|
|
Refs #5586
|
|
Plus:
- Fix a bug on `html_options` in AF83::Decorator::Link
- Add a `t` helper in AF83::Decorator to handle i18n
|
|
|
|
5024-prevent-duplicate-referentials-from-being-created-during-parallel-db-transactions--rb201711271659
|
|
|
|
build_referenial invocation in ReferentialsController#create. Refs #5297
|
|
Refs #5297
|
|
When a "duplicate referential" action is initiated, show a flash message
to let users know that it started and is in progress (and will take a
while since it's an asynchronous task).
Refs #5317
|
|
Call `#t` directly since we can and because the rest of the controller
does this without the `I18n.` prefix.
Refs #5317
|
|
* Luc specified a new flash message string to use here. Update the old
one with the new version.
* Move the translation key to `notice.referentials.validate` because we
have multiple "operation_in_progress" messages (this one for
validation, and another for referential cloning/duplication).
* Add a test to confirm that the flash message is set.
Refs #5317
|
|
5024-prevent-duplicate-referentials-from-being-created-during-parallel-db-transactions--rb201711271659
Conflicts:
app/models/referential.rb
A whitespace conflict in a place I don't even remember editing? Okaay.
|
|
|
|
Rename the method to `build_referential`. Saw it because my project grep
didn't work.
Refs #5024
|
|
add specs
|
|
ComplianceControlSetCopyWorker, and change routes/views for select compliance_control_set
|
|
|
|
Refs #4741
|
|
- Add some context to referential and workbench decorator to access current_referential and assign it to the cloned referential
- Add a build_referential method to avoir duplicates of code (in the controller and in the model), need to clean a bit more
- Need to add some Spec features to take into account the functional scope of the current_user
|
|
Added params to certains paths to have the workbench_id in it.
The goal is to have the current workbench_id to assign it when do a Referential#new_from
Then I finished the use of the functional scope to avoid potential errors
I skipped some tests that hve a #TODO so we can easily find them
|
|
|
|
regarding the functional scope of the current organozation
|
|
Refs #4132
|
|
Needed to add a new decorator to provide links to this table's gear
menu. The links correspond to those in the header on the
"referential_lines/show.html.slim" page.
Call `#human_attribute_name` on the model directly instead of the
collection because the decorated collection doesn't expose that method.
Refs #3479
|
|
|
|
- PolicyChecker authorizes(*) all now
- Untied ApplicationPolicy#index? from show?
- mv access_point_policy.rb to access_point_policy.rb fixing an invisible name curruption (local problem?)
* to authorize: to allow (not here), to undergo the process of authorization (here)
|
|
3479-refactor-table_builder-helper
|
|
Refs #3657
|
|
Refs #3657
|
|
I hadn't used this syntax before because I think I had tried:
@referential.decorate
without the assignment. Of course it didn't work at the time, but I
didn't notice so I switched to this syntax which did work.
Use the shorter one because it's a bit cleaner.
Refs #3479
|
|
Add a new `ReferentialDecorator` that we can use to define the links
that appear as buttons in the header of the `/referentials/:id` page.
The idea is that these links will take the place of the existing view
code and in the view, we'll instead loop over the links provided by the
decorator and render them as buttons.
I decided to do it this way because there's a requirement that the links
in the gear menu in tables show the same links that appear in the header
of the page. So the Workbenches#show page would show a table of
referentials, and their gear menu links should ostensibly be the same as
the header links in the Referentials#show page.
My goal was to abstract links, and try to separate them from the
presentation layer. Still having trouble with this though. I created a
new `Link` class to represent a link. We can then use this in the
template to create a `link_to`. It becomes messy, though, when we want
to put other elements inside a certain link, as evidenced by the
`:delete` link. Don't like how that's done, but still working out the
best approach to make it cleaner.
Refs #3479
|
|
Method was indented by three spaces. Should be two.
Refs #3479
|
|
passes current_organization down from the controller into Reference.new_from
adds joint models *ReferenceMemeberships to excluded Apartment models
|
|
|
|
|
|
This reverts commit 3c97164c390c3001f656d174b80f8a87d57d60ef.
|
|
|
|
ReferentialSupport and ReferentialsController. Refs #2900
|
|
Refs #2858
|
|
|
|
|
|
|
|
|
|
referential; in progress
|
|
|
|
|