| Age | Commit message (Collapse) | Author |
|---|
|
- fix of RouteObserver#after_destroy (dead code right now, but see below)
- change specs to use Route#destroy in order to trigger `dependent: :destroy' in stop_points
(#delete does not work as stop_points is used in `has_many :stop_areas, through:', no doc found on this behavior, but #destroy is the advocated method to be used)
|
|
|
|
|
|
|
|
- fix of RouteObserver#after_destroy (dead code right now, but see below)
- change specs to use Route#destroy in order to trigger `dependent: :destroy' in stop_points
(#delete does not work as stop_points is used in `has_many :stop_areas, through:', no doc found on this behavior, but #destroy is the advocated method to be used)
|
|
|
|
Signed-off-by: Thomas Shawarma Haddad <thomas.haddad@af83.com>
|
|
|
|
|
|
|
|
Signed-off-by: Thomas Shawarma Haddad <thomas.haddad@af83.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
3301-vehicle-journey-times--can,t-click-inputs-on-journey-columns-with-errors
|
|
|
|
|
|
|
|
|
|
|
|
When an error occurred when modifying a time in a journey pattern, it
would be surrounded by a red box. The trouble is, you wouldn't be able
to click inside that box to focus the inputs and change times once the
box was added.
The problem happens on this page:
http://stif-boiv.dev:3000/referentials/4/lines/158/routes/1/vehicle_journeys
This was due to the z-index placing the box on a layer closer to the
front than the inputs, eating click events and preventing them from
being clicked on.
Originally I thought about using `pointer-events: none;` but according
to http://caniuse.com/#search=pointer-events it isn't supported in
IE < 11. Eliminated the `z-index` instead which has the same effect and
doesn't appear to cause any visual problems, at least on the page I
mentioned. Only tested in Opera TBH.
Refs #3301
|
|
af83/3268-vehicle-journey-times--order-vehicle-journeys-display-journey-with-earliest-stop-first--rb20170504170900
VehicleJourneysCtl#collection: Use VehicleJourney.with_stops
|
|
Use the class method to get the vehicle journeys in the proper order of
departure time ascending.
The `.with_stops` method replicates this same SQL sequence of joins and
order.
Refs #3268
|
|
af83/3268-vehicle-journey-times--order-vehicle-journeys-display-journey-with-earliest-stop-first--rb20170504170900
3268 vehicle journey times order vehicle journeys display journey with earliest stop first rb20170504170900
|
|
If a journey is missing one or more stops at the beginning of the route,
it should be sorted by the first stop it stops at.
Given these journeys:
| 1 | 2 | 3
-------+-------+-------+------
Stop 1 | 10:00 | | 10:15
Stop 2 | 10:10 | 10:12 | 10:25
Stop 3 | 10:20 | 10:18 | 10:35
Journey should appear in between 1 and 3 because its first stop is
between 10:00 and 10:15.
Move the `initialize_stop_times` helper function outside of the first
test in this `describe` so we can use it again in this test.
Refs #3268
|
|
Simplify the "orders journeys with nil times at the end" test. Instead
of manually initialising our data, create a special factory for the
empty vehicle journey that we need. This allows us to get rid of the
nonsense in the test setup.
The existing `:vehicle_journey` factory still works the same as before.
Refs #3268
|
|
Empty journeys, or vehicle journeys with an empty
`vehicle_journey_at_stops` collection should be sorted at the end of the
list.
Refs #3268
|
|
A new method that does the same thing as the query in
`VehicleJourneysController#collection`
(4c12a6632907d5d24b654791db994bfb830c7e37). The goal is to replace the
controller query code with this method so that it can be unit tested.
Refs #3268
|
|
Correctly sort journeys. They used to be sorted correctly this way, but
after d7c6d5ce602219b9bfa47686542dd575f1fe2e50 or
c3d207301d17538b65d2a1239ce0acf642942ce9, the sorting got messed up
because of the join.
Here we leverage `journey_patterns.departure_stop_point_id` in order to
get the first stop and sort by that stop's departure time. Query
solution thanks to Luc and Alban, who remembered that a reference to the
first stop point is stored so we can leverage that for complex things
like this.
Refs #3268
|
|
easy change locale for testing and developping translations
|
|
|
|
Refs #3298
|
|
Signed-off-by: Thomas Shawarma Haddad <thomas.haddad@af83.com>
|
|
|
|
|
|
|
|
* use a single transaction
* use by default workbench 1
* use a random line found in workbench lines
|
|
Refs #3291
|
|
|
|
Signed-off-by: Thomas Shawarma Haddad <thomas.haddad@af83.com>
|
|
|
|
|
|
|
|
|
|
Signed-off-by: Thomas Shawarma Haddad <thomas.haddad@af83.com>
|
|
|
|
Signed-off-by: Thomas Shawarma Haddad <thomas.haddad@af83.com>
|
