| Age | Commit message (Collapse) | Author |
|---|
|
Refs #4581
|
|
Refs #4563
|
|
Refs #4579
|
|
|
|
af83/3520-workbench--add-output-association-to-ReferentialSuite
3520 workbench add output association to referential suite
|
|
Instead of creating the objects directly in ActiveRecord, use our
existing factories for these records as suggested by Robert.
Refs #3520
|
|
Leverage our existing factories instead of creating the objects on the
models directly.
Refs #3520
|
|
4440 add permissions to imports
|
|
Add small helper to create a clone from the window variable the backend send to the JS part
We then only deal with variable shared within the app and not with window variable than we delete if we specify it
|
|
Add trad to React itineraries
|
|
|
|
|
|
Added Controller Spec
Fixed Older Specs
|
|
|
|
ImportPolicy changing *.imports →' imports.*
|
|
|
|
|
|
|
|
|
|
|
|
Existing `Workbench`es don't have associated `ReferentialSuite`s in
their `output` fields. The new requirement is that all `Workbench`es
must have a `ReferentialSuite`.
To enforce this for existing `Workbench` records, this data migration
creates new (empty) `ReferentialSuite`s for each existing `Workbench`.
Not performant at all, and I'm worried I'm missing some edge case, but
this is the gist of it.
Refs #3520
|
|
Since the `output` attribute is now initialised automatically in the
`Workbench#initialize_output` `before_validation` callback, the one I
added here before I created the callback can be removed. Instead we'll
rely on the callback to create a new `ReferentialSuite` for us.
Refs #3520
|
|
Since all `Workbench`es must have an associated `ReferentialSuite` via
`output`, if none is provided when creating a new `Workbench`, create
one automatically.
This is done in a `before_validation` callback (eck, AR callbacks).
In order for our prior 'should validate_presence_of' test to continue to
work, we have to work around the new callback, otherwise Shoulda can't
set `output` to `nil` to run its expectation and the test fails.
Refs #3520
|
|
Ensure all workbenches always have an associated `ReferentialSuite` by
validating presence of the `output` attribute.
In order to pass the 'should have a valid factory' test, we need to
define a `ReferentialSuite` factory and set up a default association on
`output` in the `Workbench` factory.
We also need to add set `output` when creating a `Workbench` in
`spec/support/referential.rb`, otherwise we get a validation error that
breaks the tests. Clean up the formatting of that call. In order to pass
a `ReferentialSuite`, I just create one above, but I'm not sure if I
should be using a `find_or_create` mechanism like the other associated
objects do above.
Refs #3520
|
|
|
|
|
|
The `output` attribute should be a `ReferentialSuite`.
Refs #3520
|
|
This column will be a reference to a `ReferentialSuite`. Going forward,
all `Workbench`es will be required to have an associated
`ReferentialSuite`.
Refs #3520
|
|
af83/4401-compliance-control-ModelAttribute--address-Robert,s-comments
4401 compliance control model attribute address robert,s comments
|
|
|
|
|
|
Recommendation from Robert. The `@__all__` is an implementation detail.
It's more fragile to use `#instance_variable_set` in each test. Instead,
put that part in a `before` block so that if we decide to change it, we
only have to do so in one place.
Now each test can blithely assume that `ModelAttribute.all` starts out
as an empty list.
Refs #4401
|
|
Thanks to Robert for this suggestion, of course it makes a lot of sense
to verify class equivalence when checking equality.
Refs #4401
|
|
Call `#uniq` right after mapping over the `klass` attribute.
Recommendation from Robert (thanks!). This means there are less elements
to deal with in the subsequent maps.
Refs #4401
|
|
- Added functions to itineraries/form_helper to handle empty fields and modifiy input regarding the user input
- Update the stop point checker to not add the error span each time the user hit the form's submit button
|
|
3519 create referential suite model
|
|
`ReferentialSuite` has many `Referential`s. Need to add a foreign key
column to the `referentials` table to allow that to work.
Refs #3519
|
|
This model is responsible for collecting referentials in order to merge
them into a single referential.
* `new` corresponds to a referential in the process of being validated
* `current` corresponds to the most recently validated referential
Refs #3519
|
|
Object ID
=> Change the way provider_id in constructed to replace every space with an underscore.
|
|
af83/4401-create-compliance-control-model-attribute-class
4401 create compliance control model attribute class
|
|
Enables finding a `ModelAttribute` by a string code combining klass and
name.
Refs #4401
|
|
Object ID
=> Change the way provider_id in constructed to replace every space with an underscore.
|
|
This returns all defined `ModelAttribute`s as a hash of class keys
containing lists of the attributes they contain.
Refs #4401
|
|
This allows people to get a list of the classes defined in
`ModelAttribute`. The classes are turned into constant-cased strings.
Not sure if that's useful, but this is how it was described in the
ticket.
Refs #4401
|
|
This enables filtering by class like `.methods_by_class` and
additionally only selecting attributes matching a certain data type.
Refs #4401
|
|
In c9a997f337c9b45f62b50629de96fa95f20c1a7f, we changed the storage
mechanism of `all` and made it not a class method. Update the spec
description to reflect this.
Refs #4401
|
|
|
|
|
|
|
|
|
