Merge branch 'master' into 3562_ccset_affectation3562_ccset_affectation

15 files changed, 214 insertions, 39 deletions

diff --git a/spec/controllers/statuses_controller_spec.rb b/spec/controllers/statuses_controller_spec.rb
new file mode 100644
index 000000000..8a6db8e28
--- /dev/null
+++ b/spec/controllers/statuses_controller_spec.rb
@@ -0,0 +1,50 @@
+RSpec.describe StatusesController, :type => :controller do
+
+  describe "GET index" do
+    login_user
+    render_views
+
+
+    let(:request){ get :index}
+    let(:parsed_response){ JSON.parse response.body }
+    it "should be ok" do
+      request
+      expect(response).to have_http_status 200
+      expect(parsed_response["status"]).to eq "ok"
+    end
+    context "without blocked object" do
+      before do
+        create :referential
+        create :import
+        create :compliance_check_set
+        request
+      end
+
+      it "should be ok" do
+        expect(response).to have_http_status 200
+        expect(parsed_response["status"]).to eq "ok"
+        expect(parsed_response["referentials_blocked"]).to eq 0
+        expect(parsed_response["imports_blocked"]).to eq 0
+        expect(parsed_response["imports_blocked"]).to eq 0
+      end
+    end
+
+    context "with a blocked object" do
+      before do
+        create :referential, created_at: 5.hours.ago, ready: false
+        create :import
+        create :compliance_check_set
+        request
+      end
+
+      it "should be ko" do
+        expect(Referential.blocked.count).to eq 1
+        expect(response).to have_http_status 200
+        expect(parsed_response["status"]).to eq "ko"
+        expect(parsed_response["referentials_blocked"]).to eq 1
+        expect(parsed_response["imports_blocked"]).to eq 0
+        expect(parsed_response["imports_blocked"]).to eq 0
+      end
+    end
+  end
+end
diff --git a/spec/factories/chouette_routes.rb b/spec/factories/chouette_routes.rb
index 7443d08bc..92a50b924 100644
--- a/spec/factories/chouette_routes.rb
+++ b/spec/factories/chouette_routes.rb
@@ -19,6 +19,7 @@ FactoryGirl.define do
       after(:create) do |route, evaluator|
         create_list(:stop_point, evaluator.stop_points_count, route: route)
         route.reload
+        route.update_checksum!
       end
 
       factory :route_with_journey_patterns do
diff --git a/spec/factories/compliance_controls/vehicle_journey_control_factories.rb b/spec/factories/compliance_controls/vehicle_journey_control_factories.rb
index e8f68cbdf..86a335aba 100644
--- a/spec/factories/compliance_controls/vehicle_journey_control_factories.rb
+++ b/spec/factories/compliance_controls/vehicle_journey_control_factories.rb
@@ -1,10 +1,12 @@
 FactoryGirl.define do
 
   factory :vehicle_journey_control_wating_time, class: 'VehicleJourneyControl::WaitingTime' do
+    maximum 10
     association :compliance_control_set
   end
 
   factory :vehicle_journey_control_delta, class: 'VehicleJourneyControl::Delta' do
+    maximum 10
     association :compliance_control_set
   end
 
diff --git a/spec/models/chouette/footnote_spec.rb b/spec/models/chouette/footnote_spec.rb
index fc5e5f306..05f55c2f0 100644
--- a/spec/models/chouette/footnote_spec.rb
+++ b/spec/models/chouette/footnote_spec.rb
@@ -1,12 +1,12 @@
 require 'spec_helper'
 
 describe Chouette::Footnote, type: :model do
-  let(:footnote) { create(:footnote) }
+  subject { create(:footnote) }
   it { should validate_presence_of :line }
 
   describe 'data_source_ref' do
     it 'should set default if omitted' do
-      expect(footnote.data_source_ref).to eq "DATASOURCEREF_EDITION_BOIV"
+      expect(subject.data_source_ref).to eq "DATASOURCEREF_EDITION_BOIV"
     end
 
     it 'should not set default if not omitted' do
@@ -18,16 +18,16 @@ describe Chouette::Footnote, type: :model do
   end
 
   describe 'checksum' do
-    it_behaves_like 'checksum support', :footnote
+    it_behaves_like 'checksum support'
 
     context '#checksum_attributes' do
       it 'should return code and label' do
-        expected = [footnote.code, footnote.label]
-        expect(footnote.checksum_attributes).to include(*expected)
+        expected = [subject.code, subject.label]
+        expect(subject.checksum_attributes).to include(*expected)
       end
 
       it 'should not return other atrributes' do
-        expect(footnote.checksum_attributes).to_not include(footnote.updated_at)
+        expect(subject.checksum_attributes).to_not include(subject.updated_at)
       end
     end
   end
diff --git a/spec/models/chouette/journey_pattern_spec.rb b/spec/models/chouette/journey_pattern_spec.rb
index b5eb9004c..19a74a0e7 100644
--- a/spec/models/chouette/journey_pattern_spec.rb
+++ b/spec/models/chouette/journey_pattern_spec.rb
@@ -2,9 +2,10 @@ require 'spec_helper'
 
 describe Chouette::JourneyPattern, :type => :model do
   it { is_expected.to be_versioned }
+  subject { create(:journey_pattern) }
 
   describe 'checksum' do
-    it_behaves_like 'checksum support', :journey_pattern
+    it_behaves_like 'checksum support'
   end
 
   # context 'validate minimum stop_points size' do
diff --git a/spec/models/chouette/route/route_base_spec.rb b/spec/models/chouette/route/route_base_spec.rb
index 26f57eae5..98cb3e358 100644
--- a/spec/models/chouette/route/route_base_spec.rb
+++ b/spec/models/chouette/route/route_base_spec.rb
@@ -1,8 +1,8 @@
 RSpec.describe Chouette::Route, :type => :model do
-
   subject { create(:route) }
+
   describe 'checksum' do
-    it_behaves_like 'checksum support', :route
+    it_behaves_like 'checksum support'
   end
 
   it { is_expected.to enumerize(:direction).in(:straight_forward, :backward, :clockwise, :counter_clockwise, :north, :north_west, :west, :south_west, :south, :south_east, :east, :north_east) }
diff --git a/spec/models/chouette/routing_constraint_zone_spec.rb b/spec/models/chouette/routing_constraint_zone_spec.rb
index 0282cb8b1..bda6bb04a 100644
--- a/spec/models/chouette/routing_constraint_zone_spec.rb
+++ b/spec/models/chouette/routing_constraint_zone_spec.rb
@@ -11,7 +11,7 @@ describe Chouette::RoutingConstraintZone, type: :model do
   it { is_expected.to be_versioned }
 
   describe 'checksum' do
-    it_behaves_like 'checksum support', :routing_constraint_zone
+    it_behaves_like 'checksum support'
   end
 
   describe 'validations' do
diff --git a/spec/models/chouette/time_table_period_spec.rb b/spec/models/chouette/time_table_period_spec.rb
index cc1a3ae09..e14d38ade 100644
--- a/spec/models/chouette/time_table_period_spec.rb
+++ b/spec/models/chouette/time_table_period_spec.rb
@@ -10,7 +10,7 @@ describe Chouette::TimeTablePeriod, :type => :model do
   it { is_expected.to validate_presence_of :period_end }
 
   describe 'checksum' do
-    it_behaves_like 'checksum support', :time_table_period
+    it_behaves_like 'checksum support'
   end
 
   describe "#overlap" do
diff --git a/spec/models/chouette/time_table_spec.rb b/spec/models/chouette/time_table_spec.rb
index 6e5da2c67..fe4bd3cfa 100644
--- a/spec/models/chouette/time_table_spec.rb
+++ b/spec/models/chouette/time_table_spec.rb
@@ -1048,7 +1048,7 @@ end
   # it { is_expected.to validate_uniqueness_of :objectid }
 
   describe 'checksum' do
-    it_behaves_like 'checksum support', :time_table
+    it_behaves_like 'checksum support'
 
     it "handles newly built dates and periods" do
       time_table = build(:time_table)
diff --git a/spec/models/chouette/vehicle_journey_at_stop_spec.rb b/spec/models/chouette/vehicle_journey_at_stop_spec.rb
index 02306883c..a97559a0c 100644
--- a/spec/models/chouette/vehicle_journey_at_stop_spec.rb
+++ b/spec/models/chouette/vehicle_journey_at_stop_spec.rb
@@ -1,10 +1,12 @@
 require 'spec_helper'
 
 RSpec.describe Chouette::VehicleJourneyAtStop, type: :model do
+  subject { create(:vehicle_journey_at_stop) }
+
   describe 'checksum' do
     let(:at_stop) { build_stubbed(:vehicle_journey_at_stop) }
 
-    it_behaves_like 'checksum support', :vehicle_journey_at_stop
+    it_behaves_like 'checksum support'
 
     context '#checksum_attributes' do
       it 'should return attributes' do
diff --git a/spec/models/chouette/vehicle_journey_spec.rb b/spec/models/chouette/vehicle_journey_spec.rb
index 7279980a3..76e73d9cf 100644
--- a/spec/models/chouette/vehicle_journey_spec.rb
+++ b/spec/models/chouette/vehicle_journey_spec.rb
@@ -1,6 +1,8 @@
 require 'spec_helper'
 
 describe Chouette::VehicleJourney, :type => :model do
+  subject { create(:vehicle_journey) }
+
   it { is_expected.to be_versioned }
   it { should have_and_belong_to_many(:purchase_windows) }
 
@@ -21,7 +23,7 @@ describe Chouette::VehicleJourney, :type => :model do
   end
 
   describe 'checksum' do
-    it_behaves_like 'checksum support', :vehicle_journey
+    it_behaves_like 'checksum support'
     it "changes when a vjas is updated" do
       vehicle_journey = create(:vehicle_journey)
       expect{vehicle_journey.vehicle_journey_at_stops.last.update_attribute(:departure_time, Time.now)}.to change{vehicle_journey.reload.checksum}
diff --git a/spec/models/compliance_check_spec.rb b/spec/models/compliance_check_spec.rb
index f83d78c29..ffa59245c 100644
--- a/spec/models/compliance_check_spec.rb
+++ b/spec/models/compliance_check_spec.rb
@@ -15,4 +15,36 @@ RSpec.describe ComplianceCheck, type: :model do
   it { should validate_presence_of :name }
   it { should validate_presence_of :code }
   it { should validate_presence_of :origin_code }
+
+  describe ".abort_old" do
+    it "changes check sets older than 4 hours to aborted" do
+      Timecop.freeze(Time.now) do
+        old_check_set = create(
+          :compliance_check_set,
+          status: 'pending',
+          created_at: 4.hours.ago - 1.minute
+        )
+        current_check_set = create(:compliance_check_set, status: 'pending')
+
+        ComplianceCheckSet.abort_old
+
+        expect(current_check_set.reload.status).to eq('pending')
+        expect(old_check_set.reload.status).to eq('aborted')
+      end
+    end
+
+    it "doesn't work on check sets with a `finished_status`" do
+      Timecop.freeze(Time.now) do
+        check_set = create(
+          :compliance_check_set,
+          status: 'successful',
+          created_at: 4.hours.ago - 1.minute
+        )
+
+        ComplianceCheckSet.abort_old
+
+        expect(check_set.reload.status).to eq('successful')
+      end
+    end
+  end
 end
diff --git a/spec/models/import_spec.rb b/spec/models/import_spec.rb
index ffb2360c2..8b85f151b 100644
--- a/spec/models/import_spec.rb
+++ b/spec/models/import_spec.rb
@@ -29,6 +29,58 @@ RSpec.describe Import, type: :model do
     )
   end
 
+  describe ".abort_old" do
+    it "changes imports older than 4 hours to aborted" do
+      Timecop.freeze(Time.now) do
+        old_import = create(
+          :workbench_import,
+          status: 'pending',
+          created_at: 4.hours.ago - 1.minute
+        )
+        current_import = create(:workbench_import, status: 'pending')
+
+        Import.abort_old
+
+        expect(current_import.reload.status).to eq('pending')
+        expect(old_import.reload.status).to eq('aborted')
+      end
+    end
+
+    it "doesn't work on imports with a `finished_status`" do
+      Timecop.freeze(Time.now) do
+        import = create(
+          :workbench_import,
+          status: 'successful',
+          created_at: 4.hours.ago - 1.minute
+        )
+
+        Import.abort_old
+
+        expect(import.reload.status).to eq('successful')
+      end
+    end
+
+    it "only works on the caller type" do
+      Timecop.freeze(Time.now) do
+        workbench_import = create(
+          :workbench_import,
+          status: 'pending',
+          created_at: 4.hours.ago - 1.minute
+        )
+        netex_import = create(
+          :netex_import,
+          status: 'pending',
+          created_at: 4.hours.ago - 1.minute
+        )
+
+        NetexImport.abort_old
+
+        expect(workbench_import.reload.status).to eq('pending')
+        expect(netex_import.reload.status).to eq('aborted')
+      end
+    end
+  end
+
   describe "#destroy" do
     it "must destroy all child imports" do
       netex_import = create(:netex_import)
diff --git a/spec/services/parent_import_notifier_spec.rb b/spec/services/parent_notifier_spec.rb
index 3ab505f88..ecf508fcd 100644
--- a/spec/services/parent_import_notifier_spec.rb
+++ b/spec/services/parent_notifier_spec.rb
@@ -1,4 +1,4 @@
-RSpec.describe ParentImportNotifier do
+RSpec.describe ParentNotifier do
   let(:workbench_import) { create(:workbench_import) }
 
   describe ".notify_when_finished" do
@@ -20,7 +20,7 @@ RSpec.describe ParentImportNotifier do
         expect(netex_import).to receive(:notify_parent)
       end
 
-      ParentImportNotifier.notify_when_finished(netex_imports)
+      ParentNotifier.new(Import).notify_when_finished(netex_imports)
     end
 
     it "doesn't call #notify_parent if its `notified_parent_at` is set" do
@@ -33,11 +33,11 @@ RSpec.describe ParentImportNotifier do
 
       expect(netex_import).not_to receive(:notify_parent)
 
-      ParentImportNotifier.notify_when_finished
+      ParentNotifier.new(Import).notify_when_finished
     end
   end
 
-  describe ".imports_pending_notification" do
+  describe ".objects_pending_notification" do
     it "includes imports with a parent and `notified_parent_at` unset" do
       netex_import = create(
         :netex_import,
@@ -47,7 +47,7 @@ RSpec.describe ParentImportNotifier do
       )
 
       expect(
-        ParentImportNotifier.imports_pending_notification
+        ParentNotifier.new(Import).objects_pending_notification
       ).to eq([netex_import])
     end
 
@@ -55,7 +55,7 @@ RSpec.describe ParentImportNotifier do
       create(:import, parent: nil)
 
       expect(
-        ParentImportNotifier.imports_pending_notification
+        ParentNotifier.new(Import).objects_pending_notification
       ).to be_empty
     end
 
@@ -70,7 +70,7 @@ RSpec.describe ParentImportNotifier do
       end
 
       expect(
-        ParentImportNotifier.imports_pending_notification
+        ParentNotifier.new(Import).objects_pending_notification
       ).to be_empty
     end
 
@@ -83,7 +83,7 @@ RSpec.describe ParentImportNotifier do
       )
 
       expect(
-        ParentImportNotifier.imports_pending_notification
+        ParentNotifier.new(Import).objects_pending_notification
       ).to be_empty
     end
   end
diff --git a/spec/support/checksum_support.rb b/spec/support/checksum_support.rb
index e02d9f9f3..f8dffb1b7 100644
--- a/spec/support/checksum_support.rb
+++ b/spec/support/checksum_support.rb
@@ -1,25 +1,23 @@
-shared_examples 'checksum support' do |factory_name|
-  let(:instance) { create(factory_name) }
-
+shared_examples 'checksum support' do
   describe '#current_checksum_source' do
     let(:attributes) { ['code_value', 'label_value'] }
-    let(:seperator)  { ChecksumSupport::SEPARATOR }
+    let(:separator)  { ChecksumSupport::SEPARATOR }
     let(:nil_value)  { ChecksumSupport::VALUE_FOR_NIL_ATTRIBUTE }
 
     before do
-      allow_any_instance_of(instance.class).to receive(:checksum_attributes).and_return(attributes)
+      allow_any_instance_of(subject.class).to receive(:checksum_attributes).and_return(attributes)
     end
 
-    it 'should separate attribute by seperator' do
-      expect(instance.current_checksum_source).to eq("code_value#{seperator}label_value")
+    it 'should separate attribute by separator' do
+      expect(subject.current_checksum_source).to eq("code_value#{separator}label_value")
     end
 
     context 'nil value' do
       let(:attributes) { ['code_value', nil] }
 
       it 'should replace nil attributes by default value' do
-        source = "code_value#{seperator}#{nil_value}"
-        expect(instance.current_checksum_source).to eq(source)
+        source = "code_value#{separator}#{nil_value}"
+        expect(subject.current_checksum_source).to eq(source)
       end
     end
 
@@ -27,27 +25,62 @@ shared_examples 'checksum support' do |factory_name|
       let(:attributes) { ['code_value', []] }
 
       it 'should convert to nil' do
-        source = "code_value#{seperator}#{nil_value}"
-        expect(instance.current_checksum_source).to eq(source)
+        source = "code_value#{separator}#{nil_value}"
+        expect(subject.current_checksum_source).to eq(source)
+      end
+    end
+
+    context 'array value' do
+      let(:attributes) { [['v1', 'v2', 'v3'], 'code_value'] }
+
+      it 'should convert to list' do
+        source = "v1,v2,v3#{separator}code_value"
+        expect(subject.current_checksum_source).to eq(source)
+      end
+    end
+
+    context 'array of array value' do
+      let(:attributes) { [[['a1', 'a2', 'a3'], ['b1', 'b2', 'b3']], 'code_value'] }
+
+      it 'should convert to list' do
+        source = "(a1,a2,a3),(b1,b2,b3)#{separator}code_value"
+        expect(subject.current_checksum_source).to eq(source)
+      end
+    end
+
+    context 'array of array value, with empty array' do
+      let(:attributes) { [[['a1', 'a2', 'a3'], []], 'code_value'] }
+
+      it 'should convert to list' do
+        source = "(a1,a2,a3),-#{separator}code_value"
+        expect(subject.current_checksum_source).to eq(source)
       end
     end
   end
 
   it 'should save checksum on create' do
-    expect(instance.checksum).to_not be_nil
+    expect(subject.checksum).to_not be_nil
   end
 
   it 'should save checksum_source' do
-    expect(instance.checksum_source).to_not be_nil
+    expect(subject.checksum_source).to_not be_nil
   end
 
   it 'should trigger set_current_checksum_source on save' do
-    expect(instance).to receive(:set_current_checksum_source).at_least(:once)
-    instance.save
+    expect(subject).to receive(:set_current_checksum_source).at_least(:once)
+    subject.save
   end
 
   it 'should trigger update_checksum on save' do
-    expect(instance).to receive(:update_checksum).at_least(:once)
-    instance.save
+    expect(subject).to receive(:update_checksum).at_least(:once)
+    subject.save
+  end
+
+  it "doesn't change the checksum on save if the source hasn't been changed" do
+    checksum = subject.checksum
+
+    subject.save
+
+    expect(subject.checksum).to eq(checksum)
   end
 end