aboutsummaryrefslogtreecommitdiffstats
path: root/spec/services
diff options
context:
space:
mode:
authorTeddy Wing2017-08-25 12:14:29 +0200
committerTeddy Wing2017-08-25 12:14:29 +0200
commit166b53305e41c51f4b401514a5ec2d828788a2cd (patch)
tree5b87863e3937eb4c990fc52dbbf770509cb3345a /spec/services
parent36770fc9e7a4a8fe72d6bf7f2bc0dc328183e6fe (diff)
downloadchouette-core-166b53305e41c51f4b401514a5ec2d828788a2cd.tar.bz2
Remove `RetryService`
This is no longer being used as the `WorkbenchImportWorker` was refactored and it was decided that we don't want to enable retries for imports. For example, imagine you have an hour-long import that fails after 50 minutes. We retry three times and now we've wasted 2.5 hours of your time just to tell you that the import failed. Thus the decision was to remove it.
Diffstat (limited to 'spec/services')
-rw-r--r--spec/services/retry_service_spec.rb137
1 files changed, 0 insertions, 137 deletions
diff --git a/spec/services/retry_service_spec.rb b/spec/services/retry_service_spec.rb
deleted file mode 100644
index bb3416373..000000000
--- a/spec/services/retry_service_spec.rb
+++ /dev/null
@@ -1,137 +0,0 @@
-RSpec.describe RetryService do
- subject { described_class.new delays: [2, 3], rescue_from: [NameError, ArgumentError] }
-
- context 'no retry necessary' do
- before do
- expect( subject ).not_to receive(:sleep)
- end
-
- it 'returns an ok result' do
- expect( subject.execute { 42 } ).to eq(Result.ok(42))
- end
- it 'does not fail on nil' do
- expect( subject.execute { nil } ).to eq(Result.ok(nil))
- end
-
- it 'fails wihout retries if raising un unregistered exception' do
- expect{ subject.execute{ raise KeyError } }.to raise_error(KeyError)
- end
-
- end
-
- context 'all retries fail' do
- before do
- expect( subject ).to receive(:sleep).with(2)
- expect( subject ).to receive(:sleep).with(3)
- end
- it 'fails after raising a registered exception n times' do
- result = subject.execute{ raise ArgumentError }
- expect( result.status ).to eq(:error)
- expect( result.value ).to be_kind_of(ArgumentError)
- end
- it 'fails with an explicit try again (automatically registered exception)' do
- result = subject.execute{ raise RetryService::Retry }
- expect( result.status ).to eq(:error)
- expect( result.value ).to be_kind_of(RetryService::Retry)
- end
- end
-
- context "if at first you don't succeed" do
- before do
- @count = 0
- expect( subject ).to receive(:sleep).with(2)
- end
-
- it 'succeeds the second time' do
- expect( subject.execute{ succeed_later(ArgumentError){ 42 } } ).to eq(Result.ok(42))
- end
-
- it 'succeeds the second time with try again (automatically registered exception)' do
- expect( subject.execute{ succeed_later(RetryService::Retry){ 42 } } ).to eq(Result.ok(42))
- end
- end
-
- context 'last chance' do
- before do
- @count = 0
- expect( subject ).to receive(:sleep).with(2)
- expect( subject ).to receive(:sleep).with(3)
- end
- it 'succeeds the third time with try again (automatically registered exception)' do
- result = subject.execute{ succeed_later(RetryService::Retry, count: 2){ 42 } }
- expect( result ).to eq( Result.ok(42) )
- end
- end
-
- context 'failure callback once' do
- subject do
- described_class.new delays: [2, 3], rescue_from: [NameError, ArgumentError] do |reason, count|
- @reason=reason
- @callback_count=count
- @failures += 1
- end
- end
-
- before do
- @failures = 0
- @count = 0
- expect( subject ).to receive(:sleep).with(2)
- end
-
- it 'succeeds the second time and calls the failure_callback once' do
- subject.execute{ succeed_later(RetryService::Retry){ 42 } }
- expect( @failures ).to eq(1)
- end
- it '... and the failure is passed into the callback' do
- subject.execute{ succeed_later(RetryService::Retry){ 42 } }
- expect( @reason ).to be_a(RetryService::Retry)
- expect( @callback_count ).to eq(1)
- end
- end
-
- context 'failure callback twice' do
- subject do
- described_class.new delays: [2, 3], rescue_from: [NameError, ArgumentError] do |_reason, _count|
- @failures += 1
- end
- end
-
- before do
- @failures = 0
- @count = 0
- expect( subject ).to receive(:sleep).with(2)
- expect( subject ).to receive(:sleep).with(3)
- end
-
- it 'succeeds the third time and calls the failure_callback twice' do
- subject.execute{ succeed_later(NameError, count: 2){ 42 } }
- expect( @failures ).to eq(2)
- end
- end
-
- context 'failure callback in constructor' do
- subject do
- described_class.new(delays: [1, 2], &method(:add2failures))
- end
- before do
- @failures = []
- @count = 0
- expect( subject ).to receive(:sleep).with(1)
- expect( subject ).to receive(:sleep).with(2)
- end
- it 'succeeds the second time and calls the failure_callback once' do
- subject.execute{ succeed_later(RetryService::Retry, count: 2){ 42 } }
- expect( @failures ).to eq([1,2])
- end
- end
-
- def add2failures( e, c)
- @failures << c
- end
-
- def succeed_later error, count: 1, &blk
- return blk.() unless @count < count
- @count += 1
- raise error, 'error'
- end
-end