Refs: #4720@1.3h;

   Validation implemented for min_max_values with correct I18n'd error messages

Applied to: VehicleJourneyControl::Speed & GenericAttributeControl::MinMax

3 files changed, 10 insertions, 38 deletions

diff --git a/spec/models/compliance_control_validations/genric_attribute_validation/min_max_validation_spec.rb b/spec/models/compliance_control_validations/genric_attribute_validation/min_max_validation_spec.rb
index 409475a46..4d30d61e3 100644
--- a/spec/models/compliance_control_validations/genric_attribute_validation/min_max_validation_spec.rb
+++ b/spec/models/compliance_control_validations/genric_attribute_validation/min_max_validation_spec.rb
@@ -3,42 +3,6 @@ RSpec.describe GenericAttributeControl::MinMax do
   let( :factory ){ :generic_attribute_control_min_max }
   subject{ build factory }
 
-  context "is valid" do
-    it 'if no value is provided' do
-      expect_it.to be_valid
-    end
-    it 'if minimum is provided alone' do
-      subject.minimum = 42
-      expect_it.to be_valid
-    end
-    it 'if maximum is provided alone' do
-      subject.maximum = 42
-      expect_it.to be_valid
-    end
-
-    it 'if maximum is not smaller than minimum' do
-      100.times do
-        min = random_int
-        max = min + random_int(20)
-        subject.assign_attributes maximum: max, minimum: min
-        subject.assign_attributes maximum: min, minimum: min
-        expect_it.to be_valid
-      end
-    end
-  end
-
-  context "is invalid" do
-    it 'if maximum is smaller than minimum' do
-      100.times do
-        min = random_int
-        max = min - random_int(20) - 1
-        subject.assign_attributes maximum: max, minimum: min
-        expect_it.not_to be_valid
-      end
-    end
-
-  end
-
-  
+  it_behaves_like 'has min_max_values'
 
 end
diff --git a/spec/models/compliance_control_validations/genric_attribute_validation/pattern_validation_spec.rb b/spec/models/compliance_control_validations/genric_attribute_validation/pattern_validation_spec.rb
index 82c5c10c3..2a1d8cf5c 100644
--- a/spec/models/compliance_control_validations/genric_attribute_validation/pattern_validation_spec.rb
+++ b/spec/models/compliance_control_validations/genric_attribute_validation/pattern_validation_spec.rb
@@ -4,7 +4,7 @@ RSpec.describe GenericAttributeControl::Pattern do
   subject{ build factory }
 
   context "is valid" do
-    if 'the pattern contains a basic regex' do
+    it 'if the pattern contains a basic regex' do
       subject.pattern = 'hel+o?'
       expect_it.to be_valid
     end
diff --git a/spec/models/compliance_control_validations/vehicle_journey_validation/speed_validation_spec.rb b/spec/models/compliance_control_validations/vehicle_journey_validation/speed_validation_spec.rb
new file mode 100644
index 000000000..88316ab37
--- /dev/null
+++ b/spec/models/compliance_control_validations/vehicle_journey_validation/speed_validation_spec.rb
@@ -0,0 +1,8 @@
+RSpec.describe VehicleJourneyControl::Speed do
+
+  let( :factory ){ :vehicle_journey_control_speed }
+  subject{ build factory }
+
+  it_behaves_like 'has min_max_values'
+
+end