diff options
| author | Teddy Wing | 2018-03-15 16:19:24 +0100 | 
|---|---|---|
| committer | Teddy Wing | 2018-03-15 17:44:22 +0100 | 
| commit | fa0fdbe92d441e1a226a56c792c014a032fd46e9 (patch) | |
| tree | 07b90e265f2fe6c6f3308f379a3a311297cba16f /spec/lib | |
| parent | d43365e243a8cf9bef3a856e2bf65c9b401e78e5 (diff) | |
| download | chouette-core-fa0fdbe92d441e1a226a56c792c014a032fd46e9.tar.bz2 | |
JourneyPatternsCollection#show: Fallback to route costs
When editing a `JourneyPattern`, you can edit the distance & time costs
between stops. We want to pre-fill these cost values (in the input
fields) if they haven't already been set by a user. This way, they get
an existing estimate of the cost and don't have to enter a value
manually unless the default doesn't work.
The pre-filled values come from `Route#costs`, which get calculated
ahead of time via the TomTom API.
Add a new `fetchRouteCosts` function that will fetch the costs for the
current route from the API. This function also caches the value on
`actions` so we don't keep making requests since the data isn't going to
change. Put the cached fetch in a `requestAnimationFrame` as a sort of
timeout to prevent a warning from React complaining about doing this
during a `render()` call.
Update `getTimeAndDistanceBetweenStops` to use the cost value from the
route costs instead of the journey pattern costs if it doesn't exist.
The `totalDistance` and `totalTime` we moved into `componentWillUpdate`
instead of `render()` because we thought that might be the cause of the
`render()` warning I mentioned above. Decided to leave this part in even
though it doesn't have anything to do with the goal of the changes here,
because it seemed like an okay change.
The `RECEIVE_ROUTE_COSTS` reducer will update the state with route
costs. We need the default distance:0 time:0 to avoid infinitely
fetching the costs API if a cost with the given key can't be found.
Put the route cost API URL in `window.routeCostsUrl` to allow us to get
it from the Rails URL helper.
Huge thanks to Johan for pairing with me on this code and walking me
through the setup for integrating the route costs JSON response into the
frontend interface.
Refs #6203
Diffstat (limited to 'spec/lib')
0 files changed, 0 insertions, 0 deletions
