diff options
| author | Teddy Wing | 2017-05-22 15:11:05 +0200 |
|---|---|---|
| committer | Teddy Wing | 2017-05-22 15:38:09 +0200 |
| commit | 44712fe052e0c554c0510d4665a35c66540ffa05 (patch) | |
| tree | d519ff8221dd7c469e8026955f515cda0ae14400 /spec/javascripts | |
| parent | 897bc5fb10b1867970367ede388feac0ac1a5791 (diff) | |
| download | chouette-core-44712fe052e0c554c0510d4665a35c66540ffa05.tar.bz2 | |
VehicleJourney: Make `#exclude_journeys_without_time_tables` do opposite
Cédric clarified the task:
https://projects.af83.io/projects/stif-boiv-realisation/activity?from=2017-05-22
Apparently, the "Afficher les courses sans calendrier" filter needs to
only show vehicle journeys that have no calendar associated when toggled
to "Oui".
When I was implementing this, I had thought that it was the other way
around, and the default neutral state was "Oui", and when set to "Non",
vehicle journeys without calendars would be excluded from the list. This
was apparently wrong.
The default state should actually be "Non", and only non-calendared
vehicle journeys should appear when "Oui".
Update the test and code to reflect this. Rename
`#exclude_journeys_without_time_tables` to `#without_time_tables`
because it should now only select vehicle journeys without time tables.
We can also simplify our query quite a bit, since vehicle journeys that
have no time tables will always be distinct in the left join, so we
don't need to explicitly write an extra step in the join to do that.
Refs #3427
Diffstat (limited to 'spec/javascripts')
0 files changed, 0 insertions, 0 deletions
