Rename `RouteWayCostJSONSerializer` to `RouteWayCostUnitConverter`

Because we need to pass a Ruby hash to Rabl instead of a JSON string,
get rid of our serialiser and instead turn it into a function that just
converts the distance & time units.

Fix a bug in the test that had the `'1-2'` key as a symbol instead of a
string which was caused by a copy-paste from JSON and not being thorough
enough in search-and-replace.

Refs #6203

1 files changed, 2 insertions, 4 deletions

diff --git a/lib/route_way_cost_json_serializer.rb b/lib/route_way_cost_unit_converter.rb
index 20b3d6ee2..1aebbbb14 100644
--- a/lib/route_way_cost_json_serializer.rb
+++ b/lib/route_way_cost_unit_converter.rb
@@ -1,13 +1,11 @@
-class RouteWayCostJSONSerializer
-  def self.dump(way_costs)
+class RouteWayCostUnitConverter
+  def self.convert(way_costs)
     return if way_costs.nil?
 
     way_costs.each do |_, costs|
       costs['distance'] = self.meters_to_kilometers(costs['distance'])
       costs['time'] = self.seconds_to_minutes(costs['time'])
     end
-
-    JSON.dump(way_costs)
   end
 
   private