referentials_helper.rb#line_status: Fix style of text label

The label previously took on the colour of the icon (green or red) and
was set in Times/browser default.

It was set in the wrong style because the label was put inside the
`<span>` for the icon. To fix the problem, leave the icon `<span>` empty
and put the label just after it in a text DOM node. This makes the text
label render correctly, in black 14px Open Sans.

Also remove the unnecessary `cls` variables and ternaries as these are
already handled by the outer `if` condition.

Refs #5005

1 files changed, 4 insertions, 4 deletions

diff --git a/app/helpers/referentials_helper.rb b/app/helpers/referentials_helper.rb
index f3c18d9f8..d9fb48d01 100644
--- a/app/helpers/referentials_helper.rb
+++ b/app/helpers/referentials_helper.rb
@@ -2,11 +2,11 @@ module ReferentialsHelper
   # Line statuses helper
   def line_status(status)
     if status
-    cls = 'danger'
-      content_tag :span, status ? " #{t('false')} " : " #{t('true')}", class: "fa fa-exclamation-circle fa-lg text-#{cls}"
+      content_tag(:span, nil, class: 'fa fa-exclamation-circle fa-lg text-danger') +
+        t('false')
     else
-    cls = 'success'
-      content_tag :span, status ? " #{t('false')} " : " #{t('true')}", class: "fa fa-check-circle fa-lg text-#{cls}"
+      content_tag(:span, nil, class: 'fa fa-check-circle fa-lg text-success') +
+        t('true')
     end
   end
 end