aboutsummaryrefslogtreecommitdiffstats
path: root/app/models
diff options
context:
space:
mode:
authorTeddy Wing2017-11-09 16:44:38 +0100
committercedricnjanga2017-11-13 17:52:54 +0100
commit32d8376cd407c24a6eca5ebf2adfca3c7d9d776f (patch)
tree33f6ae8fb96c335035528055ad67af368174cebc /app/models
parentb172d774513ffbae5c8a88f39b3d4bb7e4ae51e0 (diff)
downloadchouette-core-32d8376cd407c24a6eca5ebf2adfca3c7d9d776f.tar.bz2
ComplianceCheckSet: Rename to `all_statuses_ok?`
Another suggestion from Robert, since this method returns a boolean, maybe its name should end with a question mark. Refs #4757
Diffstat (limited to 'app/models')
-rw-r--r--app/models/compliance_check_set.rb4
1 files changed, 2 insertions, 2 deletions
diff --git a/app/models/compliance_check_set.rb b/app/models/compliance_check_set.rb
index cce24410c..a133230f8 100644
--- a/app/models/compliance_check_set.rb
+++ b/app/models/compliance_check_set.rb
@@ -30,14 +30,14 @@ class ComplianceCheckSet < ActiveRecord::Base
end
end
- if all_statuses_ok(statuses)
+ if all_statuses_ok?(statuses)
return update(status: 'successful')
end
end
private
- def all_statuses_ok(statuses)
+ def all_statuses_ok?(statuses)
uniform_statuses = statuses.uniq
uniform_statuses.length == 1 && uniform_statuses.first == 'OK'
end