fix simplification

1 files changed, 10 insertions, 15 deletions

diff --git a/app/assets/javascripts/vehicle_journey.js.coffee b/app/assets/javascripts/vehicle_journey.js.coffee
index e3e66811f..b266cfa30 100644
--- a/app/assets/javascripts/vehicle_journey.js.coffee
+++ b/app/assets/javascripts/vehicle_journey.js.coffee
@@ -1,25 +1,20 @@
 jQuery ->
-  copy_departures_to_arrivals = (event) -> 
-    event.preventDefault()
+  swap_hour_minute = ( from, to) -> 
     rows =  $('.vehicle_journeys.edit tbody.journey_pattern_dependent_list tr')
     for row in rows 
       do (row) ->
-        arrival = row.children[0]
-        departure = row.children[2]
-        arrival.children[0].value = departure.children[0].value
-        arrival.children[1].value = departure.children[1].value
+        $(row).find( to).find('.hour')[0].value = $(row).find( from).find('.hour')[0].value
+        $(row).find( to).find('.minute')[0].value = $(row).find( from).find('.minute')[0].value
+
+  copy_departures_to_arrivals = (event) -> 
+    event.preventDefault()
+    swap_hour_minute( '.departure_time', '.arrival_time')
 
-  $('.vehicle_journeys.edit a.to_arrivals').click(copy_departures_to_arrivals)
+  $('.vehicle_journeys.edit a.to_arrivals').live("click", copy_departures_to_arrivals)
 
   copy_arrivals_to_departures = (event) -> 
     event.preventDefault()
-    rows =  $('.vehicle_journeys.edit tbody.journey_pattern_dependent_list tr')
-    for row in rows 
-      do (row) ->
-        arrival = row.children[0]
-        departure = row.children[2]
-        departure.children[0].value = arrival.children[0].value
-        departure.children[1].value = arrival.children[1].value
+    swap_hour_minute( '.arrival_time', '.departure_time')
 
-  $('.vehicle_journeys.edit a.to_departures').click(copy_arrivals_to_departures)
+  $('.vehicle_journeys.edit a.to_departures').live("click", copy_arrivals_to_departures)