1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
|
require "keg"
require "stringio"
describe Keg do
include FileUtils
def setup_test_keg(name, version)
path = HOMEBREW_CELLAR/name/version
(path/"bin").mkpath
%w[hiworld helloworld goodbye_cruel_world].each do |file|
touch path/"bin"/file
end
keg = described_class.new(path)
kegs << keg
keg
end
around(:each) do |example|
begin
@old_stdout = $stdout
$stdout = StringIO.new
example.run
ensure
$stdout = @old_stdout
end
end
let(:dst) { HOMEBREW_PREFIX/"bin"/"helloworld" }
let(:nonexistent) { Pathname.new("/some/nonexistent/path") }
let(:mode) { OpenStruct.new }
let!(:keg) { setup_test_keg("foo", "1.0") }
let(:kegs) { [] }
before(:each) do
(HOMEBREW_PREFIX/"bin").mkpath
(HOMEBREW_PREFIX/"lib").mkpath
end
after(:each) do
kegs.each(&:unlink)
rmtree HOMEBREW_PREFIX/"lib"
end
specify "::all" do
Formula.clear_racks_cache
expect(described_class.all).to eq([keg])
end
specify "#empty_installation?" do
%w[.DS_Store INSTALL_RECEIPT.json LICENSE.txt].each do |file|
touch keg/file
end
expect(keg).to exist
expect(keg).to be_a_directory
expect(keg).not_to be_an_empty_installation
(keg/"bin").rmtree
expect(keg).to be_an_empty_installation
(keg/"bin").mkpath
touch keg.join("bin", "todo")
expect(keg).not_to be_an_empty_installation
end
specify "#oldname_opt_record" do
expect(keg.oldname_opt_record).to be nil
oldname_opt_record = HOMEBREW_PREFIX/"opt/oldfoo"
oldname_opt_record.make_relative_symlink(HOMEBREW_CELLAR/"foo/1.0")
expect(keg.oldname_opt_record).to eq(oldname_opt_record)
end
specify "#remove_oldname_opt_record" do
oldname_opt_record = HOMEBREW_PREFIX/"opt/oldfoo"
oldname_opt_record.make_relative_symlink(HOMEBREW_CELLAR/"foo/2.0")
keg.remove_oldname_opt_record
expect(oldname_opt_record).to be_a_symlink
oldname_opt_record.unlink
oldname_opt_record.make_relative_symlink(HOMEBREW_CELLAR/"foo/1.0")
keg.remove_oldname_opt_record
expect(oldname_opt_record).not_to be_a_symlink
end
describe "#link" do
it "links a Keg" do
expect(keg.link).to eq(3)
(HOMEBREW_PREFIX/"bin").children.each do |c|
expect(c.readlink).to be_relative
end
end
context "with dry run set to true" do
it "only prints what would be done" do
mode.dry_run = true
expect(keg.link(mode)).to eq(0)
expect(keg).not_to be_linked
["hiworld", "helloworld", "goodbye_cruel_world"].each do |file|
expect($stdout.string).to match("#{HOMEBREW_PREFIX}/bin/#{file}")
end
expect($stdout.string.lines.count).to eq(3)
end
end
it "fails when already linked" do
keg.link
expect { keg.link }.to raise_error(Keg::AlreadyLinkedError)
end
it "fails when files exist" do
touch dst
expect { keg.link }.to raise_error(Keg::ConflictError)
end
it "ignores broken symlinks at target" do
src = keg/"bin"/"helloworld"
dst.make_symlink(nonexistent)
keg.link
expect(dst.readlink).to eq(src.relative_path_from(dst.dirname))
end
context "with overwrite set to true" do
it "overwrite existing files" do
touch dst
mode.overwrite = true
expect(keg.link(mode)).to eq(3)
expect(keg).to be_linked
end
it "overwrites broken symlinks" do
dst.make_symlink "nowhere"
mode.overwrite = true
expect(keg.link(mode)).to eq(3)
expect(keg).to be_linked
end
it "still supports dryrun" do
touch dst
mode.overwrite = true
mode.dry_run = true
expect(keg.link(mode)).to eq(0)
expect(keg).not_to be_linked
expect($stdout.string).to eq("#{dst}\n")
end
end
it "also creates an opt link" do
expect(keg).not_to be_optlinked
keg.link
expect(keg).to be_optlinked
end
specify "pkgconfig directory is created" do
link = HOMEBREW_PREFIX/"lib"/"pkgconfig"
(keg/"lib"/"pkgconfig").mkpath
keg.link
expect(link.lstat).to be_a_directory
end
specify "cmake directory is created" do
link = HOMEBREW_PREFIX/"lib"/"cmake"
(keg/"lib"/"cmake").mkpath
keg.link
expect(link.lstat).to be_a_directory
end
specify "symlinks are linked directly" do
link = HOMEBREW_PREFIX/"lib"/"pkgconfig"
(keg/"lib"/"example").mkpath
(keg/"lib"/"pkgconfig").make_symlink "example"
keg.link
expect(link.resolved_path).to be_a_symlink
expect(link.lstat).to be_a_symlink
end
end
describe "#unlink" do
it "unlinks a Keg" do
keg.link
expect(dst).to be_a_symlink
expect(keg.unlink).to eq(3)
expect(dst).not_to be_a_symlink
end
it "prunes empty top-level directories" do
mkpath HOMEBREW_PREFIX/"lib/foo/bar"
mkpath keg/"lib/foo/bar"
touch keg/"lib/foo/bar/file1"
keg.unlink
expect(HOMEBREW_PREFIX/"lib/foo").not_to be_a_directory
end
it "ignores .DS_Store when pruning empty directories" do
mkpath HOMEBREW_PREFIX/"lib/foo/bar"
touch HOMEBREW_PREFIX/"lib/foo/.DS_Store"
mkpath keg/"lib/foo/bar"
touch keg/"lib/foo/bar/file1"
keg.unlink
expect(HOMEBREW_PREFIX/"lib/foo").not_to be_a_directory
expect(HOMEBREW_PREFIX/"lib/foo/.DS_Store").not_to exist
end
it "doesn't remove opt link" do
keg.link
keg.unlink
expect(keg).to be_optlinked
end
it "preverves broken symlinks pointing outside the Keg" do
keg.link
dst.delete
dst.make_symlink(nonexistent)
keg.unlink
expect(dst).to be_a_symlink
end
it "preverves broken symlinks pointing into the Keg" do
keg.link
dst.resolved_path.delete
keg.unlink
expect(dst).to be_a_symlink
end
it "preverves symlinks pointing outside the Keg" do
keg.link
dst.delete
dst.make_symlink(Pathname.new("/bin/sh"))
keg.unlink
expect(dst).to be_a_symlink
end
it "preserves real files" do
keg.link
dst.delete
touch dst
keg.unlink
expect(dst).to be_a_file
end
it "ignores nonexistent file" do
keg.link
dst.delete
expect(keg.unlink).to eq(2)
end
it "doesn't remove links to symlinks" do
a = HOMEBREW_CELLAR/"a"/"1.0"
b = HOMEBREW_CELLAR/"b"/"1.0"
(a/"lib"/"example").mkpath
(a/"lib"/"example2").make_symlink "example"
(b/"lib"/"example2").mkpath
a = described_class.new(a)
b = described_class.new(b)
a.link
lib = HOMEBREW_PREFIX/"lib"
expect(lib.children.length).to eq(2)
expect { b.link }.to raise_error(Keg::ConflictError)
expect(lib.children.length).to eq(2)
end
it "removes broken symlinks that conflict with directories" do
a = HOMEBREW_CELLAR/"a"/"1.0"
(a/"lib"/"foo").mkpath
keg = described_class.new(a)
link = HOMEBREW_PREFIX/"lib"/"foo"
link.parent.mkpath
link.make_symlink(nonexistent)
keg.link
end
end
describe "#optlink" do
it "creates an opt link" do
oldname_opt_record = HOMEBREW_PREFIX/"opt/oldfoo"
oldname_opt_record.make_relative_symlink(HOMEBREW_CELLAR/"foo/1.0")
keg_record = HOMEBREW_CELLAR/"foo"/"2.0"
(keg_record/"bin").mkpath
keg = described_class.new(keg_record)
keg.optlink
expect(keg_record).to eq(oldname_opt_record.resolved_path)
keg.uninstall
expect(oldname_opt_record).not_to be_a_symlink
end
it "doesn't fail if already opt-linked" do
keg.opt_record.make_relative_symlink Pathname.new(keg)
keg.optlink
expect(keg).to be_optlinked
end
it "replaces an existing directory" do
keg.opt_record.mkpath
keg.optlink
expect(keg).to be_optlinked
end
it "replaces an existing file" do
keg.opt_record.parent.mkpath
keg.opt_record.write("foo")
keg.optlink
expect(keg).to be_optlinked
end
end
specify "#link and #unlink" do
expect(keg).not_to be_linked
keg.link
expect(keg).to be_linked
keg.unlink
expect(keg).not_to be_linked
end
describe "::find_some_installed_dependents" do
def stub_formula_name(name)
f = formula(name) { url "foo-1.0" }
stub_formula_loader f
stub_formula_loader f, "homebrew/core/#{f}"
f
end
def setup_test_keg(name, version)
f = stub_formula_name(name)
keg = super
Tab.create(f, DevelopmentTools.default_compiler, :libcxx).write
keg
end
before(:each) do
keg.link
end
def alter_tab(keg = dependent)
tab = Tab.for_keg(keg)
yield tab
tab.write
end
# 1.1.6 is the earliest version of Homebrew that generates correct runtime
# dependency lists in Tabs.
def dependencies(deps, homebrew_version: "1.1.6")
alter_tab do |tab|
tab.homebrew_version = homebrew_version
tab.tabfile = dependent/Tab::FILENAME
tab.runtime_dependencies = deps
end
end
def unreliable_dependencies(deps)
# 1.1.5 is (hopefully!) the last version of Homebrew that generates
# incorrect runtime dependency lists in Tabs.
dependencies(deps, homebrew_version: "1.1.5")
end
let(:dependent) { setup_test_keg("bar", "1.0") }
# Test with a keg whose formula isn't known.
# This can happen if e.g. a formula is installed
# from a file path or URL.
specify "unknown Formula" do
allow(Formulary).to receive(:loader_for).and_call_original
alter_tab(keg) do |t|
t.source["tap"] = "some/tap"
t.source["path"] = nil
end
dependencies [{ "full_name" => "some/tap/foo", "version" => "1.0" }]
expect(keg.installed_dependents).to eq([dependent])
expect(described_class.find_some_installed_dependents([keg])).to eq([[keg], ["bar 1.0"]])
dependencies nil
# It doesn't make sense for a keg with no formula to have any dependents,
# so that can't really be tested.
expect(described_class.find_some_installed_dependents([keg])).to be nil
end
specify "a dependency with no Tap in Tab" do
tap_dep = setup_test_keg("baz", "1.0")
alter_tab(keg) { |t| t.source["tap"] = nil }
dependencies nil
Formula["bar"].class.depends_on "foo"
Formula["bar"].class.depends_on "baz"
result = described_class.find_some_installed_dependents([keg, tap_dep])
expect(result).to eq([[keg, tap_dep], ["bar"]])
end
specify "no dependencies anywhere" do
dependencies nil
expect(keg.installed_dependents).to be_empty
expect(described_class.find_some_installed_dependents([keg])).to be nil
end
specify "missing Formula dependency" do
dependencies nil
Formula["bar"].class.depends_on "foo"
expect(keg.installed_dependents).to be_empty
expect(described_class.find_some_installed_dependents([keg])).to eq([[keg], ["bar"]])
end
specify "uninstalling dependent and dependency" do
dependencies nil
Formula["bar"].class.depends_on "foo"
expect(keg.installed_dependents).to be_empty
expect(described_class.find_some_installed_dependents([keg, dependent])).to be nil
end
specify "renamed dependency" do
dependencies nil
stub_formula_loader Formula["foo"], "homebrew/core/foo-old"
renamed_path = HOMEBREW_CELLAR/"foo-old"
(HOMEBREW_CELLAR/"foo").rename(renamed_path)
renamed_keg = described_class.new(renamed_path/"1.0")
Formula["bar"].class.depends_on "foo"
result = described_class.find_some_installed_dependents([renamed_keg])
expect(result).to eq([[renamed_keg], ["bar"]])
end
specify "empty dependencies in Tab" do
dependencies []
expect(keg.installed_dependents).to be_empty
expect(described_class.find_some_installed_dependents([keg])).to be nil
end
specify "same name but different version in Tab" do
dependencies [{ "full_name" => "foo", "version" => "1.1" }]
expect(keg.installed_dependents).to eq([dependent])
expect(described_class.find_some_installed_dependents([keg])).to eq([[keg], ["bar 1.0"]])
end
specify "different name and same version in Tab" do
stub_formula_name("baz")
dependencies [{ "full_name" => "baz", "version" => keg.version.to_s }]
expect(keg.installed_dependents).to be_empty
expect(described_class.find_some_installed_dependents([keg])).to be nil
end
specify "same name and version in Tab" do
dependencies [{ "full_name" => "foo", "version" => "1.0" }]
expect(keg.installed_dependents).to eq([dependent])
expect(described_class.find_some_installed_dependents([keg])).to eq([[keg], ["bar 1.0"]])
end
specify "fallback for old versions" do
unreliable_dependencies [{ "full_name" => "baz", "version" => "1.0" }]
Formula["bar"].class.depends_on "foo"
expect(keg.installed_dependents).to be_empty
expect(described_class.find_some_installed_dependents([keg])).to eq([[keg], ["bar"]])
end
specify "non-opt-linked" do
keg.remove_opt_record
dependencies [{ "full_name" => "foo", "version" => "1.0" }]
expect(keg.installed_dependents).to be_empty
expect(described_class.find_some_installed_dependents([keg])).to be nil
end
specify "keg-only" do
keg.unlink
Formula["foo"].class.keg_only "a good reason"
dependencies [{ "full_name" => "foo", "version" => "1.1" }] # different version
expect(keg.installed_dependents).to eq([dependent])
expect(described_class.find_some_installed_dependents([keg])).to eq([[keg], ["bar 1.0"]])
end
end
end
|