| Age | Commit message (Collapse) | Author |
|
This needs to be `Homebrew $HOMEBREW_VERSION` so we can be adequately
filtered.
Closes Homebrew/homebrew#49961.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
- Use empty array when `git credential-osxkeychain` lookup fails to
cache and avoid rerunning it when there's no valid results.
- Redirect `stderr` to avoid printing errors when there's a failure
or no `git credential-osxkeychain` installed.
Closes Homebrew/homebrew#49954.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
Users shouldn't need to fetch all of git history.
Closes Homebrew/homebrew#49903.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
This reverts commit 0525c9eeea27eff1a6de05e7a01ec268ae07437b.
Which breaks `brew update --rebase`.
|
|
Closes Homebrew/homebrew#49882.
|
|
|
|
As requested in Homebrew/homebrew#46578. Falls back to existing functionality.
Closes Homebrew/homebrew#46578.
Closes Homebrew/homebrew#49846.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
Closes Homebrew/homebrew#49874.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
|
|
Per document:
> -f, --force
> When git fetch is used with <rbranch>:<lbranch> refspec, it refuses
> to update the local branch <lbranch> unless the remote branch
> <rbranch> it fetches is a descendant of <lbranch>. This option
> overrides that check.
|
|
Closes Homebrew/homebrew#49817.
Signed-off-by: Alex Dunn <adunn@ucsb.edu>
|
|
Closes Homebrew/homebrew#49845.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
|
|
If it's not a tap, we test formula on CoreTap. This can happen
if we run test on a fork, e.g. Linuxbrew or future Homebrew/brew.
Closes Homebrew/homebrew#49844.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
Instead of hard coded `Homebrew/homebrew`
|
|
To keep backward compatibility for API name changing.
|
|
Core tap will be separated from core code in the near future.
It makes sense to rename it to CoreTap.
|
|
MLton is whole-program, optimizing compiler for Standard ML.
A previous mlton formula simply installed the upstream binary release
and was moved to the boneyard as a binary-only formula (see
Homebrew/homebrew#21780).
This new mlton formula builds from source, using the upstream binary
release to bootstrap.
Closes Homebrew/homebrew#48694.
Signed-off-by: Andrew Janke <andrew@apjanke.net>
|
|
|
|
These methods will be used in `brew --version`, `brew config`
and `brew doctor` after core/formula separation.
Closes Homebrew/homebrew#49796.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
This commit will help to mitigate bug Homebrew/homebrew#42553 on certain old Homebrew installations
(e.g. `osx_image: xcode6.4` on Travis CI) for future core/formula
separation.
On that particular Homebrew installations, `formulary.rb` will be loaded after
`git pull` is finished during `brew update`, which will then load `core_formular_repository.rb`.
By introducing `require "tap_migrations"` and `require "formula_renames"` at the top of
`core_formular_repository.rb`, we could use `tap_migrations.rb` as a
vector to preform certain hack for future core/formula separation.
|
|
Closes Homebrew/homebrew#49729.
Signed-off-by: Tim D. Smith <git@tim-smith.us>
|
|
cd to `HOMEBREW_REPOSITORY` before checking git newline settings.
Closes Homebrew/homebrew#49565.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
Closes Homebrew/homebrew#49620.
|
|
Closes Homebrew/homebrew#49551.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
|
|
Because the versions are read from directory listings, we get
alphabetical sorts of version numbers in `brew outdated` output:
some-keg (10.1.10, 10.1.11, 10.1.9 < 10.1.12)
This is nicer:
some-keg (10.1.9, 10.1.10, 10.1.11 < 10.1.12)
Closes Homebrew/homebrew#49534.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
formula_rename and tap_migrations are now handled inside Tap.
Closes Homebrew/homebrew#49549.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
If user inputs argument such as `-with-flag`, we can assume it's a bad flag.
Closes Homebrew/homebrew#49256
Closes Homebrew/homebrew#49550.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
|
|
The current approach of suppressing all output regardless of what the
error is makes it very hard to debug any issues and misread but valid
Mach-O files will be silently interpreted as non-Mach-O files instead.
Prefer to fail if we are a Homebrew developer or running on the bot
(`HOMEBREW_DEVELOPER=1`), so that problems will be noticed and fixed
before the silent failure leads to hard-to-diagnose user problems.
Closes Homebrew/homebrew#48817.
Signed-off-by: Martin Afanasjew <martin@afanasjew.de>
|
|
|
|
Closes Homebrew/homebrew#49523.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
|
|
Closes Homebrew/homebrew#48546.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
* Better variable/class name. `update-report` isn't response to actual
update.
* Use abstraction offered by Reporter and ReproterHub class.
* Failure on one tap won't affect migration preformed by other taps.
* Simplify logic and prepare for core/formula separation.
|
|
* Better variable/class name.
* Remove obsolete update_renamed, this is now handled inside each
reporter.
* Remove obsolete formula file path to name computation, which is also
handled by reporter.
* Hide low lever implementation detail to offer better abstraction.
Use `add(reporter)` instead of `Hash#update` to add new report.
|
|
* Avoid tons of unnecessary file path manipulation. Use abstraction
offered by Tap class if possible.
* Handle formula rename/tap migration inside reporter in per tap basis.
* Avoid duplicated computation.
* Remove redundant/dead code.
|
|
This enables tap migration feature in per tap case, which will
ultimately help core/formula separation.
|
|
Fixes Homebrew/homebrew#49509.
Closes Homebrew/homebrew#49511.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
* Use `Tap#formula_dir` instead of `Tap#formula_files` to find formula
file to have better performance and avoid caching issue.
* Change the loader logic to search name -> search alias -> search old name.
This is more consistence with what we do when loading core formula
file.
Closes Homebrew/homebrew#49484.
Signed-off-by: Xu Cheng <xucheng@me.com>
|
|
Recently added files polluting brew ls --unbrewed results.
Closes Homebrew/homebrew#49456.
Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
|
|
Fixes a regression introduced by Homebrew/homebrew#47950 in 9e3ee3e causing build
failures with the error
cabal: The file does not exist ''.
This will occur whenever the optional :flags key isn't in the options
hash passed to install_cabal_package.
Closes Homebrew/homebrew#49425.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
Closes Homebrew/homebrew#49404.
Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
|
|
When there are merge conflicts we fail pretty hard. This is still
possible after this commit but at least we've given Git enough pointers
to make it less likely.
Closes Homebrew/homebrew#49299.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
To address issue Homebrew/homebrew#47346 (git-annex-webapp missing), we explicitly
enable the "webapp" flag for git-annex. This should prevent git-annex
from being built without the webapp and make the build fail if there is
e.g. a dependency issue.
Closes Homebrew/homebrew#47950.
Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
|
|
Closes Homebrew/homebrew#49389.
Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
|
|
The default max-backjumps can be too low, especially since
Language::Haskell::Cabal doesn't guarantee an LTS config.
In particular, this fixes a git-annex build failure in Homebrew/homebrew#47950
Closes Homebrew/homebrew#49158.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
FileUtils::fu_get_gid only started doing the conversion of the group
to_s automatically from OS X 10.6.8 (ruby-1.8.7-p358) forward.
OS X 10.6.7 (ruby-1.8.7-p174) would fail in brew's FileUtils::mktemp with the
error "Error: can't convert Fixnum into String."
Fixes Homebrew/homebrew#49045
Fixes Homebrew/homebrew#49348
Closes Homebrew/homebrew#49369.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
|
The default HOMEBREW_LIBRARY_PATH should be
/usr/local/Library/Homebrew
not
/usr/local/Library/Homebrew/Homebrew
Closes Homebrew/homebrew#49384.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|